Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding selection on consecutive Meta+A presses buggy in Firefox doesn't work on Safari #7186

Closed
afercia opened this issue Jun 6, 2018 · 1 comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jun 6, 2018

Seems to me the new feature that allows to "Expand selection on consecutive Meta+A presses" introduced in #4600 hasn't been fully tested on all major browsers.

At a very first test, here's hat I've noticed:

  • Chrome 66: works
  • Firefox 60.0.1: buggy (macOS and Windows)
    • first meta+a: selects block content, as expected
    • second meta+a: does nothing, expected: should select all blocks
    • third meta+a: select all blocks
    • holding meta+a: selects all blocks
    • on Windows, sometimes after the first failure (that means the third step above) then a new meta+a press in a new block select all blocks (expected: should select the single block content) but couldn't reproduce consistently
  • Safari 11.1: doesn't work at all; whether I repeatedly press meta+a or hold meta+a, nothing happens
  • Edge: works
  • IE 11: works!
  • I haven't tested with screen readers on Windows

Worth noting an audible message after the selection happens would be beneficial for screen reader users, as right now there's absolutely no feedback on what happens when using meta+a.

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Jun 6, 2018
@mtias mtias added the Needs Testing Needs further testing to be confirmed. label Jul 19, 2018
@jorgefilipecosta
Copy link
Member

Closing in favor of #7445 which is more detailed.

@designsimply designsimply added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Testing Needs further testing to be confirmed. labels Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants