Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicking on formatted text, Gutenberg replaces the background color with a grey color #8113

Closed
pauljacobson opened this issue Jul 22, 2018 · 4 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Question Questions about the design or development of the editor.

Comments

@pauljacobson
Copy link

pauljacobson commented Jul 22, 2018

Describe the bug

When clicking into a section of formatted text, Gutenberg highlights all of that formatted text with a grey background, ignoring the current background color of the block the text is in.

Gutenberg doesn't select that text, however. It just highlights the formatted text.

To Reproduce

Steps to reproduce the behavior:

  1. We created a block of dummy text, added a random background color to the text.
  2. We then formatted some text as bold, italicized some text, and used strikeout for some text.
  3. We then clicked somewhere inside the formatted sections of the text.
  4. The whole section of formatted text was highlighted in a grey color, without actually selecting the text.

Expected behavior

Clicking inside formatted text need not add any further text annotation.

Screenshots

Desktop:

  • OS: macOS 10.13.6
  • Browser: Firefox 62.0b10 (Developer Edition) and Chrome 67.0.3396.99

Additional context

  • This behavior is apparent in Gutenberg v3.3.0 and WordPress.com.
  • This testing was done by myself and @thehenrybyrd
@chrisvanpatten
Copy link
Contributor

This is intentional behaviour, as part of the inline boundaries feature. This exists in the Classic Editor for links, but it is new to other types of formatting.

Would you say the problem is that it happens at all, or just that the formatting in a selected block context isn't necessary? I suspect it'd be a wontfix if the former, but the latter (not showing the inline boundaries while the whole block is elected) seems like a fair point.

@chrisvanpatten
Copy link
Contributor

Further context is available over in #459 and #2947.

@pauljacobson
Copy link
Author

@chrisvanpatten Thanks for your feedback. It's just not clear what the value of that is to a user? Adding this effect either looks like the text is being selected (which it isn't), or that there is some sort of glitch and the background is breaking up in some way (I can see users reporting this one - it's confusing).

@designsimply designsimply added [Type] Question Questions about the design or development of the editor. [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Jul 23, 2018
@youknowriad
Copy link
Contributor

This behavior have been in place for some time (even in the classic editor) and we didn't a lot negative feedback for it. Let's close and reconsider if there's more evidence that it's wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

4 participants