Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caret is oddly positioned (to the left) when undoing in Firefox #9400

Closed
tofumatt opened this issue Aug 28, 2018 · 5 comments
Closed

Caret is oddly positioned (to the left) when undoing in Firefox #9400

tofumatt opened this issue Aug 28, 2018 · 5 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended

Comments

@tofumatt
Copy link
Member

Describe the bug
When undoing a paragraph, the caret position shifts outside the block inserter and goes all the way to the left.

To Reproduce
Steps to reproduce the behavior:

  1. Add a new page
  2. Click on the block inserter
  3. Type a paragraph
  4. Press "Enter"
  5. Type another paragraph
  6. Press "Enter"
  7. Type another paragraph
  8. Press Command+Z (Control+Z on Windows/Linux)
  9. Press Command+Z (Control+Z on Windows/Linux) again

Observe the caret position; it's all the way to the left.

Expected behavior
Caret is in the previous block.

Screenshots
2018-08-28 15 55 46

Desktop (please complete the following information):

  • OS: MacOS High Sierra (10.13.6 (17G65))
  • Browser: Firefox Developer Edition
  • Version: 62.0b20 (64-bit)

Additional context

  • Latest master
@tofumatt tofumatt added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Aug 28, 2018
@tofumatt tofumatt mentioned this issue Aug 28, 2018
Merged
4 tasks
@designsimply designsimply added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Aug 28, 2018
@mtias mtias added the Needs Testing Needs further testing to be confirmed. label Nov 12, 2018
@skorasaurus
Copy link
Member

I can confirm this behavior on Gutenberg 4.5.1; wordpress 4.9.8; firefox 63 (on ubuntu 16.04)

@ellatrix
Copy link
Member

Related: #12002.

@ellatrix ellatrix removed the Needs Testing Needs further testing to be confirmed. label Nov 27, 2018
@ellatrix
Copy link
Member

Confirmed. Setting the selection back still needs to be implemented though. Sounds like a glitch in Firefox when a focussed element suddenly disappears.

@ellatrix ellatrix mentioned this issue Nov 27, 2018
Closed
@ellatrix ellatrix added the Browser Issues Issues or PRs that are related to browser specific problems label Feb 11, 2019
@ellatrix
Copy link
Member

I can no longer reproduce this issue with master. Probably fixed by #13697. Could someone confirm?

@mcsf mcsf added the [Status] Needs More Info Follow-up required in order to be actionable. label Feb 12, 2019
@youknowriad
Copy link
Contributor

yes, I can't reproduce, the caret disappears for me entirely. I guess this is part of a more global issue related to the persistence of the selection in state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tofumatt @mcsf @youknowriad @mtias @skorasaurus @designsimply @ellatrix