Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save posts/pages with specific shortcode #9923

Closed
GlennMartin1 opened this issue Sep 14, 2018 · 5 comments
Closed

Unable to save posts/pages with specific shortcode #9923

GlennMartin1 opened this issue Sep 14, 2018 · 5 comments
Labels
[Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@GlennMartin1
Copy link

Describe the bug
A post cannot save/autosave when inserting a shortcode containing the [rpwe] shortcode. This shortcode is from the plugin https://wordpress.org/plugins/recent-posts-widget-extended/

To Reproduce

  1. Install and activate Recent Posts Widget Extended https://wordpress.org/plugins/recent-posts-widget-extended/
  2. Create/modify a post/page containing a shortcode with [rpwe]
  3. Save or wait for autosave
  4. Note that save/autosave fails.
@designsimply
Copy link
Member

Any issues with a release candidate should be added to the still open milestone. Just note in the issue body the version you are testing such as 3.9.0-rc.1. (ref)

@designsimply designsimply changed the title [3.9] unable to save posts/pages with specific shortcode Unable to save posts/pages with specific shortcode Sep 15, 2018
@GlennMartin1
Copy link
Author

@designsimply Thanks - can you please add this to the 3.9 milestone?

@designsimply designsimply added this to the 3.9 milestone Sep 17, 2018
@designsimply designsimply added [Feature] Saving Related to saving functionality Needs Technical Feedback Needs testing from a developer perspective. labels Sep 17, 2018
@mcsf
Copy link
Contributor

mcsf commented Sep 20, 2018

OK, a few notes here:

  • I was able to repro in 3.8, so this isn't 3.9-specific, thus a priori invalidating the need to rush it into this milestone.
  • Saving doesn't actually fail, as confirmable via inspection of server log and saved page (or reloading the editor).
  • The issue is that the response to the POST request to save the page, while of status code 200, is malformed due to injection of markup and PHP warnings caused by operation of the plugin:

screen shot 2018-09-20 at 13 57 47

The warnings are of the following type:

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/plugins/recent-posts-widget-extended/includes/functions.php:309) in /var/www/html/wp-includes/rest-api/class-wp-rest-server.php on line 1248

I'd consider this an issue to bring to the plugin developers. In any case, I'll remove it from the 3.9 milestone.

@mcsf mcsf added [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. and removed Needs Technical Feedback Needs testing from a developer perspective. [Feature] Saving Related to saving functionality labels Sep 20, 2018
@mcsf mcsf removed this from the 3.9 milestone Sep 20, 2018
@chrisvanpatten
Copy link
Contributor

Sounds like this relates to #4936.

@designsimply
Copy link
Member

Awesome sleuthing! I learned to look deeper at API responses because of the replies here! 🤓 I might not have tried that before because I usually only scan for something other than a 200 response.

I noticed the issue was reported to the plugin developers at https://wordpress.org/support/topic/gutenberg-compatibility-15/ which is awesome, and I will close the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

4 participants