From a626473e411bc67a91baff6e4e50a3df523d1e56 Mon Sep 17 00:00:00 2001 From: Garrett Hyder Date: Sat, 2 Mar 2019 01:07:11 -0800 Subject: [PATCH 1/3] Lowercase classic editor when not in reference to the plugin. --- .../developers/backward-compatibility/meta-box.md | 2 +- .../developers/filters/editor-filters.md | 2 +- .../developers/tutorials/notices/README.md | 8 ++++---- docs/designers-developers/faq.md | 2 +- .../e2e-tests/specs/compatibility-classic-editor.test.js | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/designers-developers/developers/backward-compatibility/meta-box.md b/docs/designers-developers/developers/backward-compatibility/meta-box.md index affb67fa65a105..e7350dadba7fb3 100644 --- a/docs/designers-developers/developers/backward-compatibility/meta-box.md +++ b/docs/designers-developers/developers/backward-compatibility/meta-box.md @@ -30,7 +30,7 @@ add_meta_box( 'my-meta-box', 'My Meta Box', 'my_meta_box_callback', ); ``` -When Gutenberg is used, this meta box will no longer be displayed in the meta box area, as it now only exists for backward compatibility purposes. It will continue to display correctly in the Classic editor. +When Gutenberg is used, this meta box will no longer be displayed in the meta box area, as it now only exists for backward compatibility purposes. It will continue to display correctly in the classic editor. ### Meta Box Data Collection diff --git a/docs/designers-developers/developers/filters/editor-filters.md b/docs/designers-developers/developers/filters/editor-filters.md index 2ddb34f39f9575..9421d7cd688019 100644 --- a/docs/designers-developers/developers/filters/editor-filters.md +++ b/docs/designers-developers/developers/filters/editor-filters.md @@ -4,7 +4,7 @@ To modify the behavior of the editor experience, the following Filters are expos ### `editor.PostFeaturedImage.imageSize` -Used to modify the image size displayed in the Post Featured Image component. It defaults to `'post-thumbnail'`, and will fail back to the `full` image size when the specified image size doesn't exist in the media object. It's modeled after the `admin_post_thumbnail_size` filter in the Classic Editor. +Used to modify the image size displayed in the Post Featured Image component. It defaults to `'post-thumbnail'`, and will fail back to the `full` image size when the specified image size doesn't exist in the media object. It's modeled after the `admin_post_thumbnail_size` filter in the classic editor. _Example:_ diff --git a/docs/designers-developers/developers/tutorials/notices/README.md b/docs/designers-developers/developers/tutorials/notices/README.md index 63296f41dfb4db..a4b8a5447618c0 100644 --- a/docs/designers-developers/developers/tutorials/notices/README.md +++ b/docs/designers-developers/developers/tutorials/notices/README.md @@ -2,13 +2,13 @@ Notices are informational UI displayed near the top of admin pages. WordPress core, themes, and plugins all use notices to indicate the result of an action, or to draw the user's attention to necessary information. -In the Classic Editor, notices hooked onto the `admin_notices` action can render whatever HTML they'd like. In the Block Editor, notices are restricted to a more formal API. +In the classic editor, notices hooked onto the `admin_notices` action can render whatever HTML they'd like. In the Block Editor, notices are restricted to a more formal API. -## Notices in the Classic Editor +## Notices in the classic editor -In the Classic Editor, here's an example of the "Post draft updated" notice: +In the classic editor, here's an example of the "Post draft updated" notice: -![Post draft updated in the Classic Editor](https://raw.githubusercontent.com/WordPress/gutenberg/master/docs/designers-developers/developers/tutorials/notices/classic-editor-notice.png) +![Post draft updated in the classic editor](https://raw.githubusercontent.com/WordPress/gutenberg/master/docs/designers-developers/developers/tutorials/notices/classic-editor-notice.png) Producing an equivalent "Post draft updated" notice would require code like this: diff --git a/docs/designers-developers/faq.md b/docs/designers-developers/faq.md index eb4b21b2a1a6c2..4917ac8f82e3c1 100644 --- a/docs/designers-developers/faq.md +++ b/docs/designers-developers/faq.md @@ -322,7 +322,7 @@ We realize it's a big change. We also think there will be many new opportunities There is a “Classic” block, which is virtually the same as the current editor, except in block form. -There is also the [Classic Editor Plugin](https://wordpress.org/plugins/classic-editor/) which restores the previous editor, see the plugin for more information. The WordPress Core team has committed to supporting the Classic Editor Plugin [until December 2021](https://make.wordpress.org/core/2018/11/07/classic-editor-plugin-support-window/). +There is also the [Classic Editor plugin](https://wordpress.org/plugins/classic-editor/) which restores the previous editor, see the plugin for more information. The WordPress Core team has committed to supporting the Classic Editor plugin [until December 2021](https://make.wordpress.org/core/2018/11/07/classic-editor-plugin-support-window/). ## How will custom TinyMCE buttons work in Gutenberg? diff --git a/packages/e2e-tests/specs/compatibility-classic-editor.test.js b/packages/e2e-tests/specs/compatibility-classic-editor.test.js index 6134361af73fed..9b311275b72961 100644 --- a/packages/e2e-tests/specs/compatibility-classic-editor.test.js +++ b/packages/e2e-tests/specs/compatibility-classic-editor.test.js @@ -3,7 +3,7 @@ */ import { createNewPost, insertBlock, publishPost } from '@wordpress/e2e-test-utils'; -describe( 'Compatibility with Classic Editor', () => { +describe( 'Compatibility with classic editor', () => { beforeEach( async () => { await createNewPost(); } ); From 603e6f34dd9b9092408a6c00a1eed8d88de75d39 Mon Sep 17 00:00:00 2001 From: Garrett Hyder Date: Sun, 3 Mar 2019 20:41:09 -0800 Subject: [PATCH 2/3] Reverted heading to use capitalized as the heading choice throughout uses full capitalization style on headings so went back to make consistent as @torres126 recommended. Also updated the snap file to resolve the Travis CI error. --- .../__snapshots__/compatibility-classic-editor.test.js.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/e2e-tests/specs/__snapshots__/compatibility-classic-editor.test.js.snap b/packages/e2e-tests/specs/__snapshots__/compatibility-classic-editor.test.js.snap index e310008a220d3f..3115d36a3b64c6 100644 --- a/packages/e2e-tests/specs/__snapshots__/compatibility-classic-editor.test.js.snap +++ b/packages/e2e-tests/specs/__snapshots__/compatibility-classic-editor.test.js.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Compatibility with Classic Editor Should not apply autop when rendering blocks 1`] = ` +exports[`Compatibility with classic editor Should not apply autop when rendering blocks 1`] = ` " Random Link " From 15f4eb48565eefb852ab557a356776be49b7b4c0 Mon Sep 17 00:00:00 2001 From: Garrett Hyder Date: Sun, 3 Mar 2019 20:42:51 -0800 Subject: [PATCH 3/3] Missed saving README.md where the revert on headding capitalization was in my editor. --- .../designers-developers/developers/tutorials/notices/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/designers-developers/developers/tutorials/notices/README.md b/docs/designers-developers/developers/tutorials/notices/README.md index a4b8a5447618c0..1819ce88db03ff 100644 --- a/docs/designers-developers/developers/tutorials/notices/README.md +++ b/docs/designers-developers/developers/tutorials/notices/README.md @@ -4,7 +4,7 @@ Notices are informational UI displayed near the top of admin pages. WordPress co In the classic editor, notices hooked onto the `admin_notices` action can render whatever HTML they'd like. In the Block Editor, notices are restricted to a more formal API. -## Notices in the classic editor +## Notices in the Classic Editor In the classic editor, here's an example of the "Post draft updated" notice: