From be1db75df56b2275982d366c2e21f6c35585a839 Mon Sep 17 00:00:00 2001 From: chad1008 <13856531+chad1008@users.noreply.github.com> Date: Wed, 8 Jun 2022 15:16:10 -0400 Subject: [PATCH 1/2] Modal: add `bodyOpenClassName` to `useEffect` deps --- packages/components/src/modal/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/modal/index.js b/packages/components/src/modal/index.js index de86220f03bbe6..4d19e6f6fadb13 100644 --- a/packages/components/src/modal/index.js +++ b/packages/components/src/modal/index.js @@ -89,7 +89,7 @@ function Modal( props, forwardedRef ) { ariaHelper.showApp(); } }; - }, [] ); + }, [ bodyOpenClassName ] ); function handleEscapeKeyDown( event ) { if ( From 3aa3bd2cd3d9a28f2ae2437020fb4a12089c1f2d Mon Sep 17 00:00:00 2001 From: chad1008 <13856531+chad1008@users.noreply.github.com> Date: Wed, 8 Jun 2022 15:43:00 -0400 Subject: [PATCH 2/2] Modal: update changelog --- packages/components/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 0ddf7c5e512112..3054f5482a49b5 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -27,6 +27,8 @@ - Enhance the TypeScript migration guidelines ([#41669](https://github.com/WordPress/gutenberg/pull/41669)). - `ExternalLink`: Convert to TypeScript ([#41681](https://github.com/WordPress/gutenberg/pull/41681)). - `InputControl` updated to satisfy `react/exhuastive-deps` eslint rule ([#41601](https://github.com/WordPress/gutenberg/pull/41601)) +- `Modal`: updated to satisfy `react/exhuastive-deps` eslint rule ([#41610](https://github.com/WordPress/gutenberg/pull/41610)) + ## 19.12.0 (2022-06-01)