Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider SSR vs. CSR in end-to-end tests #554

Open
zackkrida opened this issue May 16, 2022 · 0 comments
Open

Consider SSR vs. CSR in end-to-end tests #554

zackkrida opened this issue May 16, 2022 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

Problem

We often have rendering issues that involve discrepancies between the client-side rendered page and the server-rendered version, due to the multiple ways of fetching data with Nuxt and Vue.

Description

Could we find a way to run all of our e2e tests in both SSR and CSR, and compare those images? Maybe something simple like a wrapper that runs each test twice, once directly on the route being tested and once on the route being tested after a client-side navigation from a different page. There might be even simpler ways of doing this that don't involve test changes or setup code.

@zackkrida zackkrida added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels May 16, 2022
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed ✨ goal: improvement Improvement to an existing user-facing feature 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels May 25, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants