php-wasm/node: Update express to newest version, and move it to devDependencies #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having some timeout issue with tests passing locally, but it could be just my machine. Let's wait with this PR until we fix the build (I'm working on it today) and can confirm all tests pass. |
|
The build and e2e should pass now. @eliot-akira would you rebase? |
adamziel
pushed a commit
to WordPress/playground-tools
that referenced
this pull request
Apr 12, 2024
#225) This is the second part of solving: - #224 The first part is WordPress/wordpress-playground#1218. (php-wasm/node: Update express to newest version, and move it to devDependencies) ## Why? The first part of the solution is in the Playground project, which updates `express` and moves it to `devDependencies` since it's only used for tests in that project. As a result, `express` will no longer be installed when `@php-wasm/node` is installed. So `wp-now` needs to declare `express` as a dependency. ## How? - Add `express` to `dependencies` - Update `follow-redirects` to newest `1.15.6` These together with WordPress/wordpress-playground#1218 will resolve the original issue #224, which should eliminate all npm audit warnings. ## Testing Instructions Currently `npm run test` fails with an unrelated issue, as can be seen in another PR's CI test run. https://github.com/WordPress/playground-tools/actions/runs/8616282863/job/23614052137?pr=223#step:4:49 ("RuntimeError: memory access out of bounds") That seems have been caused by commit [133029c](133029c).
…unused express-fileupload and follow-redirects
eliot-akira
force-pushed
the
update-express
branch
from
a8e0846 to
caf353d
Compare
|
OK, I rebased from trunk, force pushed, and tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This is the first part of solving WordPress/playground-tools#224 (wp-now: Resolve npm audit warnings).
expressto newest4.19.2devDependenciesexpress-fileuploadandfollow-redirectsWhat problem is it solving?
It updates
expressto the newest version with security vulnerabilities fixed.How is the problem addressed?
In addition to updating it, it's moved to
devDependenciesbecauseexpressis only used in tests.This consequently removes
expressfrom being installed when installing@php-wasm/node.The PR also removes unnecessary dependencies,
express-fileuploadandfollow-redirects, which are only used forwp-nowin the Playground Tools project.Testing Instructions
npm run test