Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP crash message not logged #474

Closed
adamziel opened this issue May 30, 2023 · 1 comment
Closed

PHP crash message not logged #474

adamziel opened this issue May 30, 2023 · 1 comment
Labels
[Feature] PHP.wasm [Type] Bug An existing feature does not function as intended

Comments

@adamziel
Copy link
Collaborator

@wojtekn reported in #470 that this happens since the PR was merged:

I also noticed that now it doesn't log the exit message from PHP, which was zend_mm_heap corrupted.

The exit message was visible in #416 (comment). Let's make sure it remains visible to the developer.
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Feature] PHP.wasm labels May 30, 2023
@adamziel adamziel mentioned this issue Jun 2, 2023
Open
@adamziel adamziel mentioned this issue Nov 22, 2023
Open
@adamziel adamziel modified the milestone: PHP Feature Parity Feb 29, 2024
@adamziel adamziel modified the milestones: PHP Feature Parity, Zero Crashes Feb 29, 2024
@adamziel
Copy link
Collaborator Author

The original issue is no longer reproducible and the error reporting was greatly improved since then. I'm closing this one for now. Let's reopen if the original problem and poor logging ever reemerges.

@adamziel adamziel closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] PHP.wasm [Type] Bug An existing feature does not function as intended
Projects
Playground Board
Archived in project
Playground High-Level Overview
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamziel