Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle (expand/collapse) the code snippets #53

Closed
ryelle opened this issue Jun 1, 2022 · 1 comment
Closed

Toggle (expand/collapse) the code snippets #53

ryelle opened this issue Jun 1, 2022 · 1 comment
Labels
[Component] Syntax Highlighting Related to the code snippets & syntax highlighter

Comments

@ryelle
Copy link
Contributor

ryelle commented Jun 1, 2022

The previous site used 12 lines as the cutoff, but let's see what looks best.

If the code snippet is longer than 12 lines, it should default to collapsed, with a link/button (it should have the behavior of a button, for a11y) to expand it.

Screen Shot 2022-06-01 at 11 09 05 AM
@ryelle ryelle added the [Component] Syntax Highlighting Related to the code snippets & syntax highlighter label Jun 1, 2022
@ryelle
Copy link
Contributor Author

ryelle commented Jun 1, 2022

Closing in favor of #22 (duplicate)

@ryelle ryelle closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Syntax Highlighting Related to the code snippets & syntax highlighter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryelle