Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubious makeRequest function #9

Open
BananaAcid opened this issue Apr 5, 2020 · 3 comments
Open

dubious makeRequest function #9

BananaAcid opened this issue Apr 5, 2020 · 3 comments
Labels

Comments

@BananaAcid
Copy link

What does it do? Why does a connect to http://www.umei.cc/p/gaoqing/cn/ ? It will at least make my Windows Firewall open up for that remote URL, and make that site register my IP.

Does not seem to be needed for the plugin. Better to remove it, or document its purpose.

Found at
https://github.com/Wscats/compile-hero/blob/master/vscode-extension/src/extension.ts#L234

@Wscats
Copy link
Owner

Wscats commented Apr 22, 2020

This is a code snippet that has not been used. @BananaAcid

@b1mind
Copy link

b1mind commented May 6, 2020

I too was wondering about this.

@Wscats
Copy link
Owner

Wscats commented May 6, 2020

@b1m1nd Because I originally planned to provide a postman-like function before, but due to time constraints, I have left this unused code.

@Wscats Wscats added the question label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants