Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for localization (translation)? #404

Closed
SiongSng opened this issue May 20, 2021 · 20 comments
Closed

Support for localization (translation)? #404

SiongSng opened this issue May 20, 2021 · 20 comments
Labels
area:settings Improves the settings of existing features. status:confirmed type:enhancement New feature or request type:new feature A new hack/command/etc. type:translation

Comments

@SiongSng
Copy link
Contributor

Description

Will Wurst support localization?
I would like to translate Wurst through the lang file so that other users can translate Wurst into their language as well.

@SiongSng SiongSng added the type:enhancement New feature or request label May 20, 2021
@Alexander01998
Copy link
Member

Yes. I want to add localization support and I have started working on it. Check out the i18n branch if you would like to submit some translations.

Currently only descriptions of hacks can be translated. I want to add translation support for other descriptions in the future.

However, the names of hacks/commands/etc will not get translation support. This ensures that everyone can use the same commands, keybinds, etc. regardless of their language setting. It also makes it easier to communicate with someone who uses Wurst in a different language.

If you encounter any descriptions that mention a specific feature by name, please keep the name in English.

@Alexander01998 Alexander01998 added status:confirmed type:new feature A new hack/command/etc. area:settings Improves the settings of existing features. labels May 20, 2021
@SiongSng
Copy link
Contributor Author

I got it, thank you.

@SiongSng
Copy link
Contributor Author

Sorry for the interruption, is there an estimated time of arrival (ETA) from the i18n branch to the master branch?

@Alexander01998
Copy link
Member

Alexander01998 commented Jul 16, 2021

I plan to merge the i18n branch into master once it's ready to be included in a Wurst update.
With the current amount of translations I think it's still too early to release this feature.

@SiongSng
Copy link
Contributor Author

Ok thanks for your reply

@Alexander01998
Copy link
Member

Update: I have changed my mind and merged the i18n branch into master. This should make it easier to work with and help to attract more translators.

I have also marked the translation feature as experimental, so that end users should not be confused about the current lack of translations.

@Alexander01998
Copy link
Member

I am seeing more and more cases where translators are disagreeing about how something should be translated. Of course, I can't resolve these conflicts by simply checking with Google Translate and trying to guess which translation is better, in a language that I don't even speak.

I think we might need some kind of community voting system, so that people who natively speak these languages can vote on each individual translation, rather than me trying to choose between entire pull requests that contain up to 137 translations each.

@SiongSng
Copy link
Contributor Author

SiongSng commented Nov 8, 2021

You can use translation platforms such as Crowdin, Weblate, etc., which have community voting capabilities

@MineYuanlu
Copy link
Contributor

I suggest that in the search function, you can search the translated language and original English at the same time.

@KTibow
Copy link
Contributor

KTibow commented Dec 25, 2021

Implemented. Consider closing?

@b1ek
Copy link

b1ek commented Jan 23, 2022

I can help with the Russian translation

@Alexander01998
Copy link
Member

@b1ek We already have Russian translations of all hack descriptions. Only a few tooltips in AltManager are currently missing Russian translations.

Please talk to @faseri if you think the current Russian translations should be improved. Please do NOT simply open another Pull Request with different translations, as I don't natively speak Russian and thus have no way of knowing which translation is better.

@b1ek
Copy link

b1ek commented Jan 23, 2022

@Alexander01998 sorry, i didn't know that. You should add a list with translated languages somewhere so this won't happen again.

@Alexander01998
Copy link
Member

@b1ek I agree. I've added a table to the README file.

@ghost
Copy link

ghost commented Mar 18, 2022

Hi, Alex!
I sent this on Twitter, but since you seem to be not that active on it, let me post it here too!

I and a friend of mine found that you're looking for the translators yesterday, and checked the current translations on Github, but it seems all the strings in Japanese translation are "translated" by using Google translate (and as you may not know, Google translate sucks, especially on Japanese), so we're currently re-translating every single string ourselves.
Could you replace the file when the translating is done please? Not sure when exactly, but we've already translated all the strings and all we need to do left is only proofreading, so it'd be done soon!

@Alexander01998
Copy link
Member

@skidderrom Great! I have been looking for a Japanese proofreader for some time.

I actually asked on Twitter if anyone could proofread that translation before I merge it, but at the time nobody replied. Eventually I just merged it, hoping that someone would eventually notice if anything is wrong with it. Seems like that's exactly what happened now. :)

BTW, Twitter doesn't notify me about DMs for some reason. I only saw your message now. A tweet usually works better.

@ghost
Copy link

ghost commented Mar 19, 2022

@Alexander01998 Thank you for the reply!
I'm sorry if I'm dumb, but how should I upload the file when the translating is done?
I'm supposed to fork the repo, update the ja_jp file, and make a pull request, right?

@Alexander01998
Copy link
Member

I'm supposed to fork the repo, update the ja_jp file, and make a pull request, right?

Yes.

You can actually do this all in the browser by clicking the pen icon here.
image

Or, if you set it up locally with Eclipse and all that, it will let you preview the translations in-game before submitting.

@ghost
Copy link

ghost commented Mar 19, 2022

@Alexander01998 Thank you for the help! <3
Just made a pull request. ;)

@Alexander01998
Copy link
Member

I've replaced the big translations table in the readme file with GitHub's new "Projects Beta" feature. It's kind of like Notion, but built into GitHub.

The overview of how many strings have been translated to each language is now here: https://github.com/orgs/Wurst-Imperium/projects/4/views/1

And an overview of all pending translations and their status is now here: https://github.com/orgs/Wurst-Imperium/projects/4/views/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings Improves the settings of existing features. status:confirmed type:enhancement New feature or request type:new feature A new hack/command/etc. type:translation
Projects
None yet
Development

No branches or pull requests

5 participants