Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Changer will broken with other language in vP #25

Closed
0944-tw opened this issue Apr 30, 2023 · 5 comments
Closed

Element Changer will broken with other language in vP #25

0944-tw opened this issue Apr 30, 2023 · 5 comments
Assignees
Labels
bug Something isn't working complete This is considered complete.

Comments

@0944-tw
Copy link

0944-tw commented Apr 30, 2023

No description provided.

@4yx
Copy link
Member

4yx commented Apr 30, 2023

This is unfortunately expected, as Element Changer searches and modifies the elements based on their appearance name, which changes when the language is changed, therefore resulting in the script not finding the element it needs to modify.

I can't think of a way where translations could be implemented into the script so that it looks for them as well, so this takes me back to my early implementation with the numerical system (https://github.com/WybeNetwork/VistaPanel-Customizations/tree/2.1.0/element-changer) which should work, but was very complicated for the average user and inefficient so it was scrapped.

Not sure how to proceed on this.

@4yx 4yx added the bug Something isn't working label Apr 30, 2023
@4yx 4yx self-assigned this Apr 30, 2023
@PlanetTheCloud
Copy link
Collaborator

Wow, really? I guess it's understandable but as @4yx mentioned, we'll have to think of a system so it's easier on the end user.

@PlanetTheCloud
Copy link
Collaborator

Also another note is that the numerical system might break when new features are added, messing up the ordering. A way to check that and remove thw correct element is required. Right now I have the idea to use the icons as anchor points, but I'll have to check on it tomorrow.

@PlanetTheCloud
Copy link
Collaborator

Fixed it, and updated the documentation as well.
Thanks for reporting.

@4yx
Copy link
Member

4yx commented May 1, 2023

Out of curiosity, how is this less prone to breaking compared to the numerical system? Maybe with the ordering as you mention but this still suffers from the original issue, oh well can't have everything.

@4yx 4yx added the complete This is considered complete. label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete This is considered complete.
Projects
None yet
Development

No branches or pull requests

3 participants