-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element Changer will broken with other language in vP #25
Comments
This is unfortunately expected, as Element Changer searches and modifies the elements based on their appearance name, which changes when the language is changed, therefore resulting in the script not finding the element it needs to modify. I can't think of a way where translations could be implemented into the script so that it looks for them as well, so this takes me back to my early implementation with the numerical system (https://github.com/WybeNetwork/VistaPanel-Customizations/tree/2.1.0/element-changer) which should work, but was very complicated for the average user and inefficient so it was scrapped. Not sure how to proceed on this. |
Wow, really? I guess it's understandable but as @4yx mentioned, we'll have to think of a system so it's easier on the end user. |
Also another note is that the numerical system might break when new features are added, messing up the ordering. A way to check that and remove thw correct element is required. Right now I have the idea to use the icons as anchor points, but I'll have to check on it tomorrow. |
Fixed it, and updated the documentation as well. |
Out of curiosity, how is this less prone to breaking compared to the numerical system? Maybe with the ordering as you mention but this still suffers from the original issue, oh well can't have everything. |
No description provided.
The text was updated successfully, but these errors were encountered: