Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite SubscriptionManager to async framework (Version: [2.1.0]) #1209

Closed
godexsoft opened this issue Feb 26, 2024 · 1 comment
Closed

Rewrite SubscriptionManager to async framework (Version: [2.1.0]) #1209

godexsoft opened this issue Feb 26, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@godexsoft
Copy link
Collaborator

Summary

SubscriptionManager still uses std::thread.
Looks like we don't need ioContext_ in SubscriptionManager itself.

Solution

Rewrite std::thread to async framework.
Also delete unused ioContext_.

Paths Not Taken

Keep std::thread in codebase

@godexsoft godexsoft added the enhancement New feature or request label Feb 26, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Feb 26, 2024
@godexsoft
Copy link
Collaborator Author

Subscription manager was rewritten and uses io_context on a number of threads. This can be rewritten using AsyncFramework.

@godexsoft godexsoft added this to the 2.3 milestone Jun 18, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Merged in Clio Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Merged
Development

No branches or pull requests

1 participant