Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Keys / Tokens in separate file #3438

Open
carlhua opened this issue Jun 4, 2020 · 1 comment
Open

Validator Keys / Tokens in separate file #3438

carlhua opened this issue Jun 4, 2020 · 1 comment
Assignees
Labels
Feature Request Used to indicate requests to add new features RIPD Export Exported from legacy JIRA issue tracking

Comments

@carlhua
Copy link
Contributor

carlhua commented Jun 4, 2020

Summary

Currently, configuring a server to validate involves creating either a [validator_seed] entry or a [validator_token] entry.

This is a problem because those entries contain the information necessary to validate and can be accidentally leaked when a validator operator is asking for assistance and is instructed to show parts of their configuration.

We should store the necessary data (seed or token) in a separate file that is either referenced by name in the main config or specified by a command line option.

For example:
[validator]
credentials=/path/to/whatever

Or:

/opt/ripple/bin/rippled --validator-credentials=/path/to/whatever

Exported from RIPD-1716

@carlhua carlhua added Feature Request Used to indicate requests to add new features RIPD Export Exported from legacy JIRA issue tracking labels Jun 4, 2020
@carlhua
Copy link
Contributor Author

carlhua commented Jun 4, 2020

Scott Determan wrote:

How about adding a general purpose way to include other files in our config file? Syntax TBD, but as a placeholder I like
@path/to/file

That syntax is from a thread about adding includes to toml here: toml-lang/toml#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features RIPD Export Exported from legacy JIRA issue tracking
Projects
None yet
Development

No branches or pull requests

2 participants