Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT make sure OfferCreate respects reserves #4

Closed
ahbritto opened this issue Dec 18, 2012 · 1 comment
Closed

UT make sure OfferCreate respects reserves #4

ahbritto opened this issue Dec 18, 2012 · 1 comment

Comments

@ahbritto
Copy link
Contributor

OfferCreate should act as described: https://ripple.com/wiki/Accounts#Reserves

OfferCreate should succeed if it takes any offers.

OfferCreate should be a partial success if takes no offers and has insufficient reserves to create the offer.

OfferCreate should only create the offer if has sufficient reserves.
@gmosx gmosx mentioned this issue Mar 16, 2013
Closed
@BobWay BobWay mentioned this issue Jun 26, 2013
Closed
This was referenced Jul 1, 2013
Closed
Closed
@alexdupre alexdupre mentioned this issue Jul 11, 2013
Closed
@vinniefalco
Copy link
Contributor

If this is still a problem please create a new issue.

@professorhantzen professorhantzen mentioned this issue Mar 11, 2018
Closed
@dmitryrn dmitryrn mentioned this issue Jun 12, 2019
Closed
ximinez referenced this issue in ximinez/rippled Aug 14, 2019
@ximinez
[FOLD] Review feedback #4:
5f61eff 
* More test cases for XRPAmount's mulratio function.
* Improve TaggedFee::json to work with non-integral types. Add tests.
ximinez referenced this issue in ximinez/rippled Aug 19, 2019
@ximinez
[FOLD] Review feedback #4:
1d45c37 
* More test cases for XRPAmount's mulratio function.
* Improve TaggedFee::json to work with non-integral types. Add tests.
ximinez referenced this issue in ximinez/rippled Aug 26, 2019
@ximinez
[FOLD] Review feedback #4:
5c0d000 
* More test cases for XRPAmount's mulratio function.
* Improve TaggedFee::json to work with non-integral types. Add tests.
ximinez referenced this issue in ximinez/rippled Sep 9, 2019
@ximinez
[FOLD] Review feedback #4:
e0030cd 
* More test cases for XRPAmount's mulratio function.
* Improve TaggedFee::json to work with non-integral types. Add tests.
ximinez referenced this issue in ximinez/rippled Oct 2, 2019
@ximinez
[FOLD] Review feedback #4:
dc36ccc 
* More test cases for XRPAmount's mulratio function.
* Improve TaggedFee::json to work with non-integral types. Add tests.
@luleigreat luleigreat mentioned this issue Dec 14, 2021
Open
@mtrippled mtrippled mentioned this issue Mar 13, 2023
Merged
6 tasks
This was referenced Mar 23, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahbritto @vinniefalco