This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Allow Digital and SingleAxis input actions for teleport #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/721-teleport-input-action
SimonDarksideJ
suggested changes
Dec 21, 2020
XRTK.SDK/Packages/com.xrtk.sdk/Runtime/Features/UX/Scripts/Pointers/TeleportPointer.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
First issue. |
|
Not an issue but to be expected. How is it supposed to work with only a single axis / digital input? |
| else | ||
| { | ||
| IsTeleportRequestActive = true; | ||
| BaseCursor?.SetVisibility(false); |
There was a problem hiding this comment.
Let's do a traditional null check on the unity engine object types
There was a problem hiding this comment.
Agreed. I'll change that in another PR as this code was not introduced in this PR and I don't want to trigger another build on this one. Need this to release to continue testing.
|
Ok, as per discussion, PR is fine as is. Turning is not supported with Digital or Single Axis. This will be addressed in 0.3 with a new Locomotion Feature |
SimonDarksideJ
approved these changes
Dec 21, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Update validator default profile * Get TeleportAction from system in TeleportPointer * Prepare TeleportPointer handling for Digital/SingleAxis * Fix TeleportPointer inspector still reasing obsolete fields * Implement digital teleport action * Remove logs * Implement single axis teleport * Use > instead of >= * FInalize and clean up * Assign default teleport action in SDK * Bump core dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Companion PR to XRTK/com.xrtk.core#729