Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux>=6.10 Onload routing is broken in presence of TOS #262

Open
ol-alexandra opened this issue Feb 6, 2025 · 0 comments
Open

linux>=6.10 Onload routing is broken in presence of TOS #262

ol-alexandra opened this issue Feb 6, 2025 · 0 comments

Comments

@ol-alexandra
Copy link
Contributor

Linux have slightly changed IP TOS management, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=338bb57e4c2a1c2c6fc92f9c0bd35be7587adca7. As a result, Socket test --tester-run=sockapi-ts/sockopts/ip_tos:env=VAR.env.peer2peer,sock_type=tcp_passive,precedence_bits=FALSE,with_cmsg=FALSE fails on linux>=6.10 and on the latest Ubuntu kernels starting from linux-6.8.0-50. I also see issues with some custom applications.

I see 2 possible approaches:

  • (easy) remove TOS policy routing support from Onload;
  • (hard) fix it.

Please note that currently Onload perfectly routes by TOS even with new kernels; it breaks when TOS is somehow used, but there is no policy routing set.

If AMD Onload team agrees to remove TOS policy routing support, then I'm ready to provide a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant