Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelocationTools.revertRouting does not really revert #393

Closed
eddieh-xlnx opened this issue Apr 19, 2022 · 0 comments · Fixed by #863
Closed

RelocationTools.revertRouting does not really revert #393

eddieh-xlnx opened this issue Apr 19, 2022 · 0 comments · Fixed by #863
Assignees
Labels

Comments

@eddieh-xlnx
Copy link
Collaborator

private static void revertRouting(List<Pair<Net, List<PIP>>> oldRoute) {
for (Pair<Net,List<PIP>> e : oldRoute) {
e.getFirst().setPIPs(e.getSecond());
}
}

is effectively a NOOP because it's modifying the list of references (to the same set of references) but not actually changing the referent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant