Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Engine was not running" message should be printed not only when debug enabled #312

Open
dmitrym1 opened this issue Jan 17, 2025 · 0 comments · May be fixed by #316
Open

"Engine was not running" message should be printed not only when debug enabled #312

dmitrym1 opened this issue Jan 17, 2025 · 0 comments · May be fixed by #316

Comments

@dmitrym1
Copy link

In current code, message "Engine was not running!!! Clearing status\n" is printed with dbg_tfr macro that only prints when module is built with LIBXDMA_DEBUG flag. However, building with this flag enables many other debug messages and bloats the log. I suggest to replace dbg_tfr with pr_err for this message. This message only appears when XDMA IP says that transaction is complete but the kernel module did not expect that (because it timed out previously or some other error). In other words, this message shows that there was a synchronization issue between requester and completer parts of the driver. So this message should be a good starting point for further diagnostics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant