You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we have thousands of modelines in the xdummy config (r16160), the server can take too long to startup. ie: r20970
This is more of a problem on low-power devices: #1777
This was recorded in #1557#comment:11: This makes the Xdummy server a little bit slower to start, so r16252 increases the timeout used in the automated tests.
Looking at the Xorg server code, there is a 3-level nested loop on modelines in xf86ValidateModes.
The middle loop reads: If the supplied mode names don't produce a valid mode, scan through unconsidered modePool members until one survives validation. This is done in decreasing order by mode pixel area.
The innermost loop, never actually triggers anything, its docstring says: Deal with the case where this mode wasn't considered because of a builtin mode of the same name
With a thousand modeline entries, we can end up running the strcmp millions of times...
We should be able to re-work that code to achieve the same results with a lot less CPU time.
On a decent CPU this can take multiple seconds, it should be doable under 100ms.
The text was updated successfully, but these errors were encountered:
Now that we have thousands of modelines in the xdummy config (r16160), the server can take too long to startup. ie: r20970
This is more of a problem on low-power devices: #1777
This was recorded in #1557#comment:11: This makes the Xdummy server a little bit slower to start, so r16252 increases the timeout used in the automated tests.
Looking at the Xorg server code, there is a 3-level nested loop on modelines in
xf86ValidateModes
.The middle loop reads: If the supplied mode names don't produce a valid mode, scan through unconsidered modePool members until one survives validation. This is done in decreasing order by mode pixel area.
The innermost loop, never actually triggers anything, its docstring says: Deal with the case where this mode wasn't considered because of a builtin mode of the same name
With a thousand modeline entries, we can end up running the
strcmp
millions of times...We should be able to re-work that code to achieve the same results with a lot less CPU time.
On a decent CPU this can take multiple seconds, it should be doable under 100ms.
The text was updated successfully, but these errors were encountered: