Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage #2598

Closed
totaam opened this issue Feb 17, 2020 · 3 comments
Closed

improve test coverage #2598

totaam opened this issue Feb 17, 2020 · 3 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 17, 2020

Split from #2356

@totaam
Copy link
Collaborator Author

totaam commented Feb 17, 2020

Important: whenever we run a server or client as subprocess during the tests, the coverage tool does not record anything.. and maybe it should?

@totaam
Copy link
Collaborator Author

totaam commented Aug 28, 2020

Despite hundreds of improvements and fixes to the unit tests, the coverage is only at 56%.

Here are the worst offenders:

Module	                                     statements	missing	excluded coverage
Total	                                         61696	27312	362	56%
xpra/scripts/main.py                             2353	1533	0	35%
xpra/server/window/window_video_source.py        1670	1185	0	29%
xpra/client/gtk_base/gtk_client_window_base.py   1555	969	0	38%
xpra/server/window/window_source.py              1711	828	0	52%
xpra/server/server_core.py                       1606	767	0	52%
xpra/net/ssh.py                                  746	678	0	9%
xpra/x11/server.py                               1042	652	0	37%
xpra/client/mixins/window_manager.py             1089	597	0	45%
xpra/client/gtk_base/gtk_client_base.py          1029	560	0	46%
xpra/net/file_transfer.py                        705	530	6	25%
xpra/x11/xkbhelper.py                            528	487	0	8%
xpra/platform/xposix/gui.py                      825	452	0	45%
xpra/x11/x11_server_core.py                      741	405	0	45%
xpra/client/gtk_base/gtk_tray_menu_base.py       1354	394	0	71%
xpra/x11/gtk_x11/clipboard.py                    532	363	0	32%
xpra/client/gl/gl_window_backing_base.py         867	353	0	59%

@totaam
Copy link
Collaborator Author

totaam commented Sep 8, 2020

This will do for 4.1, will follow up in #2873.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant