Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qrcode connection string #2627

Closed
totaam opened this issue Mar 6, 2020 · 3 comments
Closed

qrcode connection string #2627

totaam opened this issue Mar 6, 2020 · 3 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 6, 2020

Issue migrated from trac ticket # 2627

component: core | priority: major | resolution: fixed

2020-03-06 08:00:21: antoine created the issue


To make it easier to connect with an android client, generate a QR code that opens the html5 client with the correct authentication options, etc

Tested OK with pyqrencode.
There are no RPM packages for it, so this would need to be added too.

@totaam
Copy link
Collaborator Author

totaam commented Jul 4, 2020

2020-07-04 16:41:48: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Jul 4, 2020

2020-07-04 16:41:48: antoine commented


Main difficulty is that the server often does not know its public IP address.
So the qr code can more easily be generated from the client, which must have had a working URI to connect to the server.
That's what we do in r26871.

Still TODO: either figure out a way to call libqrencode using ctypes, or package python-qrencode. (at least: RPM, MSYS2, macos jhbuild..)

@totaam
Copy link
Collaborator Author

totaam commented Jul 4, 2020

2020-07-04 19:28:56: antoine commented


Updates:

  • r26872 ctypes version for when python-qrencode is not installed but libqrencode is
  • r26873 + r26878 libqrencode for macos
  • r26881 packaging for macos
  • r26876 + r26877 libqrencode for win32
  • r26879 locate library on all platforms
  • r27798 + r27800 win32 packaging fix
  • r27802 add python-qrencode to macos moduleset

Done and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant