Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra file-transfer progress bar #2678

Closed
totaam opened this issue Mar 24, 2020 · 5 comments
Closed

xpra file-transfer progress bar #2678

totaam opened this issue Mar 24, 2020 · 5 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 24, 2020

2020-03-24 14:06:19: stdedos created the issue

I've seen around Trac that there is some progress-transfer for files - at least for one direction.

  • If it's for one direction, which direction is it?
  • Where is progress shown?
  • GUI / TUI / Both?
  • If not in GUI would you consider / what are your plans to add it?
@totaam
Copy link
Collaborator Author

totaam commented Mar 24, 2020

2020-03-24 14:37:28: antoine commented


There is none at the moment, just the dialog window for accepting transfers.

It could be enhanced to show the progress.

@totaam
Copy link
Collaborator Author

totaam commented May 16, 2020

2020-05-16 18:02:46: antoine uploaded file file-transfer-progress.patch (9.4 KiB)

work in progress patch

@totaam
Copy link
Collaborator Author

totaam commented May 17, 2020

2020-05-17 10:18:26: antoine uploaded file file-transfer-progress-v2.patch (24.3 KiB)

better patch

@totaam
Copy link
Collaborator Author

totaam commented May 17, 2020

2020-05-17 17:50:59: antoine commented


Merged in r26367 (with some forgotten bits included in r26368).
This is for downloads from the server only.

This client-side improvement should work against any server version post 3.0.

@stdedos: comments / criticisms?

@totaam
Copy link
Collaborator Author

totaam commented May 19, 2020

2020-05-19 13:53:15: stdedos commented


Works and looks fine, except I cannot download any file (because #2671), so I cannot see 3/4 of the flow (cancel, progress-dl, dl-finished)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant