Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate .xpra file from html5 client connect form #2881

Closed
totaam opened this issue Sep 21, 2020 · 9 comments
Closed

generate .xpra file from html5 client connect form #2881

totaam opened this issue Sep 21, 2020 · 9 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 21, 2020

Issue migrated from trac ticket # 2881

component: html5 | priority: major | resolution: fixed

2020-09-21 09:38:04: antoine created the issue


Suggested in #2874.

@totaam
Copy link
Collaborator Author

totaam commented Oct 1, 2020

2020-10-01 13:36:49: antoine changed owner from antoine to mjharkin

@totaam
Copy link
Collaborator Author

totaam commented Oct 1, 2020

2020-10-01 13:36:49: antoine commented


  • r27565 preparatory refactoring
  • r27567 add button to launch the native client via a URI (run update-mime-database after installing the updated desktop files)
  • r27569 connection file download link

I think the URI launch is much better than using the connection file, but both are there.

@mjharkin: does that work for you?

@totaam
Copy link
Collaborator Author

totaam commented Oct 1, 2020

2020-10-01 14:17:57: mjharkin commented


@mjharkin: does that work for you?
From a quick test looks very good, thanks. I'll give it a bit more testing in the next few days. only tested connection files so far.
[[BR]]

For windows /win32/xpra.iss will need to be updated with custom protocol renaming.

[[BR]]

Also would be nice to have connect.html port set to 80/443 based on window.location.protocol if not explicitly set in url

@totaam
Copy link
Collaborator Author

totaam commented Oct 1, 2020

2020-10-01 15:40:46: antoine commented


For windows /win32/xpra.iss will need to be updated with custom protocol renaming.

Ooops, thanks. Done in r27573.

Also would be nice to have connect.html port set to 80/443 based on window.location.protocol if not explicitly set in url
Ah, right, I always test with high ports and those do get populated...
Does r27574 work for you?

@totaam
Copy link
Collaborator Author

totaam commented Oct 1, 2020

2020-10-01 20:06:20: mjharkin commented


Replying to [comment:3 Antoine Martin]:

Does r27574 work for you?
Doesn't seem to work and I think maybe this is more generic mjharkin/Xpra@a0ede78

@totaam
Copy link
Collaborator Author

totaam commented Oct 2, 2020

2020-10-02 04:28:22: antoine commented


Doesn't seem to work and I think maybe this is more generic
Thanks, applied in r27577.

Can we close this ticket?

@totaam
Copy link
Collaborator Author

totaam commented Oct 2, 2020

2020-10-02 08:30:16: mjharkin changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Oct 2, 2020

2020-10-02 08:30:16: mjharkin set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Oct 2, 2020

2020-10-02 08:30:16: mjharkin commented


Replying to [comment:5 Antoine Martin]:

Doesn't seem to work and I think maybe this is more generic
Thanks, applied in r27577.

Can we close this ticket?
Looks good, thanks. Yes, let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant