Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Debian install instructions, apt-key deprecated, new source format #3485

Closed
thkoch2001 opened this issue Mar 16, 2022 · 7 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thkoch2001
Copy link
Contributor

You might want to update the Debian / Ubuntu installation instructions on https://github.com/Xpra-org/xpra/wiki/Download#-linux

  1. apt-key is deprecated
  2. There is a new, IMHO more readable format for apt repository files

Instead of adding keys with apt-key, one should add non-armored gpg keys in a file in folder /usr/share/keyrings/. For this I changed your key with

gpg --dearmor gpg.asc

and moved the resulting file to /usr/share/keyrings/xpra.gpg.

The new source format then allows to specify, which key should be used to sign packages of which repository. The new format used the file extension .sources. So in /etc/apt/sources.list.d/xpra.sources I put:

Types: deb
URIs: https://xpra.org/
Suites: bullseye
Components: main
Signed-By: /usr/share/keyrings/xpra.gpg

For more details:

Thank you!

@thkoch2001 thkoch2001 added the enhancement New feature or request label Mar 16, 2022
@totaam totaam added the help wanted Extra attention is needed label Mar 17, 2022
@totaam
Copy link
Collaborator

totaam commented Mar 17, 2022

Since the current instructions still work, this is unlikely to be worked on just yet.

@totaam
Copy link
Collaborator

totaam commented Mar 17, 2022

See also #3446

@adamhotep
Copy link
Contributor

adamhotep commented Apr 21, 2022

Run this command:

sudo wget -O "/usr/share/keyrings/antoine-martin.gpg" https://xpra.org/gpg-2022.asc

Then download the appropriate repository file from the Download § for Debian based disributions table and modify it to include that signing key as an option:

Like this:

deb [signed-by=/usr/share/keyrings/antoine-martin.gpg] https://xpra.org/ bookworm main

If there's already an options section, it's space-delimited (see my notes):

deb [arch=amd64,arm64 signed-by=/usr/share/keyrings/antoine-martin.gpg] https://xpra.org/beta/ hirsute main

I chose to use Antoine's name for the key since it identifies itself as his personal key. You may prefer to call it xpra.gpg.

To update the docs, just update the files and the code block with my command.

(Update: the .sources format in this ticket's description is an alternative to the more traditional .list format and should also work. It'll make git diffs more legible, but given the syntax I've outlined, they're functionally equivalent.)

@totaam
Copy link
Collaborator

totaam commented Apr 21, 2022

@adamhotep thanks, do you happen to know which distributions support this format and which don't? (from both Ubuntu and Debian)

@adamhotep
Copy link
Contributor

Ubuntu and Debian develop APT together and coordinate releases to reduce this confusion, especially for the apt-key deprecation given its security concerns.

See also apt-key Is Deprecated, which notes that this applies to "Debian, Ubuntu, Linux Mint, Pop!_OS, etc."

@totaam
Copy link
Collaborator

totaam commented Apr 22, 2022

Users have criticised the download page for DEB package as being too complicated.
And these latest changes have just made things a little bit worse as we now have two different ways of importing the keys and no easy way to make it clear which one users should use... oh well.

@ehfd
Copy link

ehfd commented May 13, 2022

Instead of adding keys with apt-key, one should add non-armored gpg keys in a file in folder /usr/share/keyrings/.

This is apparently unnecessary. Just use the armored key from https://xpra.org/gpg.asc and save to /usr/share/keyrings.
The key for Wine (https://dl.winehq.org/wine-builds/winehq.key) is armored in https://wiki.winehq.org/Ubuntu and https://wiki.winehq.org/Debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants