Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide binary downloads as attachments to Github Releases #3640

Closed
gdevenyi opened this issue Oct 7, 2022 · 4 comments
Closed

Provide binary downloads as attachments to Github Releases #3640

gdevenyi opened this issue Oct 7, 2022 · 4 comments
Labels
enhancement New feature or request packaging

Comments

@gdevenyi
Copy link

gdevenyi commented Oct 7, 2022

Instead of providing downloads from a potentially comprisable host (xpra.org), you can attach official binaries to the Github releases for download.

https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

@gdevenyi gdevenyi added the enhancement New feature or request label Oct 7, 2022
@totaam
Copy link
Collaborator

totaam commented Oct 7, 2022

I very much doubt that we can attach hundreds of gigabytes to github.
That's the size of the download directory.
To compromise xpra.org, one would need to compromise my systems, at which point they could also publish compromised binaries to github.

@gdevenyi
Copy link
Author

gdevenyi commented Oct 7, 2022

Sure, I don't think it makes sense for the linux stuff, but for OSX and Windows, it may convince the security scanners that the software isn't so scary.

@totaam
Copy link
Collaborator

totaam commented Oct 7, 2022

The problem with the scanners is their new smart "AI" scanning which sees things like keylog (shorthand for keyboard logging) in the xpra source and then decides that this is malware.
The APIs that we use are also the same that real malware use: capturing keyboard input, watching the screen etc.
I don't think that the download URL is used by the virus scanners at that point.

@totaam
Copy link
Collaborator

totaam commented Oct 8, 2022

The proper way to bypass the anti-virus nonsense is probably to go via the appstore for MacOS (#1366) and MS Windows (#3923).

@totaam totaam closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging
Projects
None yet
Development

No branches or pull requests

2 participants