Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.resize resets the current slide #135

Closed
bgracie opened this issue Mar 10, 2020 · 5 comments
Closed

window.resize resets the current slide #135

bgracie opened this issue Mar 10, 2020 · 5 comments

Comments

@bgracie
Copy link

bgracie commented Mar 10, 2020

Describe the bug

Resizing the window resets the current slide

To Reproduce

  1. go to the official demo page, and the "with infinite mode" example
  2. resize the page
  3. the current slide will be reset

Expected behavior

The current slide should be maintained after the window is resized. This bug is a big problem on iOS/safari because scrolling will show or hide the URL bar (and therefore resize the window), triggering the current slide to be reset whenever the user scrolls.

@bgracie bgracie changed the title Window.resize resets the current slide window.resize resets the current slide Mar 10, 2020
@YIZHUANG
Copy link
Owner

YIZHUANG commented Mar 11, 2020

Seems like release 2.4.1 broke this. Try using a previous version for now. Will fix this.

@abhinavdalal
Copy link
Contributor

@YIZHUANG ill try have a look at this too in a day or 2..

@abhinavdalal
Copy link
Contributor

@YIZHUANG i created a pr with the fix.. i have added a test case too.. tested on my local and works as expected

@YIZHUANG
Copy link
Owner

Fixed in the latest version. Thanks @abhinavdalal

@bgracie
Copy link
Author

bgracie commented Mar 15, 2020

@YIZHUANG i created a pr with the fix.. i have added a test case too.. tested on my local and works as expected

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants