Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrongInject Source Generator API #189

Open
ettud opened this issue May 20, 2022 · 1 comment
Open

StrongInject Source Generator API #189

ettud opened this issue May 20, 2022 · 1 comment

Comments

@ettud
Copy link

ettud commented May 20, 2022

What do you think about exposing SourceGenerator and IncrementalGenerator though the separate package? E. g. if I wanted to write another source generator that writes [Register(typeof(SomeController), Scope.InstancePerResolution)] and IContainer<SomeController> for each controller in the project, it wouldn't work since source generators run separately. However, if there were some API, I could call StrongInject source generator from my source generator the same way you do it in the tests in the TestBase.cs.

@YairHalberstadt
Copy link
Owner

Hi @ettud what exactly would you like this API to look like? Do you just want the generators to be public?

My recommendation is to fork StrongInject and to get something that works. Then if it seems broadly useful I'd be happy to take the changes upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants