Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Prompt must close #4

Closed
yahu1031 opened this issue Jul 31, 2020 · 8 comments
Closed

Command Prompt must close #4

yahu1031 opened this issue Jul 31, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@yahu1031
Copy link

Greetings there,

when the installation process was cancelled by the user the command prompt that was opened ( at 25% process ) is not closing. that must be checked once.

https://drive.google.com/file/d/1xtxsWsBOOyGz8xOTDrlcJwKCxiN4h9FL/view?usp=sharing

thanks in advance.

@yahu1031 yahu1031 changed the title Command Prompts must close Command Prompt must close Aug 1, 2020
@YazeedAlKhalaf
Copy link
Owner

Okay I will look into it. Thanks for your notice 🙏

@YazeedAlKhalaf YazeedAlKhalaf added the bug Something isn't working label Aug 1, 2020
@YazeedAlKhalaf
Copy link
Owner

I believe the problem is in Process.run() itself. I am researching on how to solve it. And I have also reached out to the package owner @tekartik

GitHub Repo: https://github.com/tekartik/process_run.dart

@yahu1031
Copy link
Author

yahu1031 commented Aug 1, 2020

@YazeedAlKhalaf 😅😅 I still see some issues that needs a fix and I will update you soon. And I guess I know the solution 😁😅

@YazeedAlKhalaf
Copy link
Owner

That's great! 😁✌

@yahu1031
Copy link
Author

yahu1031 commented Aug 1, 2020

@YazeedAlKhalaf I have a suggestion for this application downloading process. can I give it here?

@YazeedAlKhalaf
Copy link
Owner

It is better to open a new issue. Sine an issue is meant to track one problem at a time.

@YazeedAlKhalaf
Copy link
Owner

@yahu1031
It seems this is a Dart specific issue, we have to wait until it is solved.
dart-lang/sdk#39945

@YazeedAlKhalaf
Copy link
Owner

@imReker gave his workaround here flutter/flutter#47891 (comment) and it was really so helpful.

I have updated the main.cpp and the problem is fixed now. A new release will be soon up 🚀.

I feel safe to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants