Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove itests. Fix jdbc url. Update Redshift jdbc driver #1

Merged
merged 1 commit into from
May 9, 2018
Merged

Remove itests. Fix jdbc url. Update Redshift jdbc driver #1

merged 1 commit into from
May 9, 2018

Conversation

dichiarafrancesco
Copy link

-Remove itests from travis: this is done by removing all the encrypted variables from .travis.conf (as per https://docs.travis-ci.com/user/environment-variables/#Convenience-Variables).
-Fix jdbc url: without ssl=true this raises an error.
-Update redshift jdbc driver to v1.2.12.1017

@dichiarafrancesco dichiarafrancesco requested a review from smoy May 9, 2018 00:29
smoy
smoy approved these changes May 9, 2018
View reviewed changes
Copy link

@smoy smoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to get travis rolling again. The explicit with ssl=true seems reasonable since people really should be using the encrypted JDBC channel.

@dichiarafrancesco dichiarafrancesco merged commit cafa05f into master May 9, 2018
sungjuly added a commit to sungjuly/spark-redshift that referenced this pull request Jan 31, 2019
@sungjuly
Cherry picking from Yelp changes
3b6a318 
* Yelp#5
* Yelp#4
* Yelp#3
* Yelp#2
* Yelp#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoy smoy smoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dichiarafrancesco @smoy