Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mui 4 -> mui 5 #22

Closed
YeonV opened this issue Oct 6, 2022 · 0 comments · Fixed by #37
Closed

mui 4 -> mui 5 #22

YeonV opened this issue Oct 6, 2022 · 0 comments · Fixed by #37
Labels
hacktoberfest Hacktoberfest 2022 xtream hacker Advanced React Knowledge needed. Expect incoming brainfuck

Comments

@YeonV
Copy link
Owner

YeonV commented Oct 6, 2022

hello hackers!

Currently Material UI v4 and v5 are both implemented.
Migrating from v4 to v5 will need manual rework, due to some breaking changes.
We gonna do it component by component. Some are already upgraded.

ToDo:

  1. Identify a v4 component, and see how it looks atm
  2. Upgrade to v5 and verify if it looks the same (colors, sizing)
  3. Fix if missmatching

Note:

v4 components are imported from '@material-ui/XXXX'
v5 components are imported from '@mui/XXXX'

Happy Hacking
@YeonV YeonV added hacktoberfest Hacktoberfest 2022 hard React Knowledge needed labels Oct 6, 2022
@YeonV YeonV added xtream hacker Advanced React Knowledge needed. Expect incoming brainfuck and removed hard React Knowledge needed labels Oct 26, 2022
This was linked to pull requests Oct 30, 2022
SpotifyPro-Integration: Add AudioAnalysis #33
Open
Scene activation = put #36
Merged
Mui5 #37
Merged
This was unlinked from pull requests Oct 30, 2022
SpotifyPro-Integration: Add AudioAnalysis #33
Open
Scene activation = put #36
Merged
@YeonV YeonV closed this as completed in #37 Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest 2022 xtream hacker Advanced React Knowledge needed. Expect incoming brainfuck
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mui5 YeonV/LedFx-Frontend-v2
1 participant
@YeonV