From c3a941706ed1d143420dd5f712644612355cd917 Mon Sep 17 00:00:00 2001 From: tigranfah Date: Thu, 23 Jan 2025 16:39:27 +0400 Subject: [PATCH] fix types of num_decays and decay_steps_perc arguments --- submitit_train.py | 2 +- torchtitan/config_manager.py | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/submitit_train.py b/submitit_train.py index 3c318e04f..89942eb83 100644 --- a/submitit_train.py +++ b/submitit_train.py @@ -51,7 +51,7 @@ "--job.config_file", train_config, "--training.steps", - "10000", + "20000", ] ) print(" ".join(function.command)) diff --git a/torchtitan/config_manager.py b/torchtitan/config_manager.py index ae922f551..75bc39176 100644 --- a/torchtitan/config_manager.py +++ b/torchtitan/config_manager.py @@ -230,19 +230,13 @@ def __init__(self): ) self.parser.add_argument( "--training.num_decays", - type=Optional[float], + type=int, default=1, help="The number of total decays to perform throughout the training, following the WSD-S scheduler", ) - self.parser.add_argument( - "--training.decay_steps", - type=Optional[int], - default=None, - help="Steps for lr scheduler decay, default is decay starts immediately after warmup", - ) self.parser.add_argument( "--training.decay_steps_perc", - type=Optional[float], + type=float, default=1.0, help="The percentage of the steps to use as decay steps", )