From 61c6c7e6a74f5b5be879bb243fe910e2e90f3fdb Mon Sep 17 00:00:00 2001 From: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Date: Thu, 26 Sep 2019 09:49:12 -0700 Subject: [PATCH] Tracing: fixed bug so tracing won't wrap None functions (#7451) * fixed bug so tracing won't wrap None functions * added opencensus threading package to dev requirements --- sdk/core/azure-core/azure/core/tracing/common.py | 2 +- sdk/core/azure-core/dev_requirements.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/core/azure-core/azure/core/tracing/common.py b/sdk/core/azure-core/azure/core/tracing/common.py index edeb690e4fb2..6b2f2c1398b5 100644 --- a/sdk/core/azure-core/azure/core/tracing/common.py +++ b/sdk/core/azure-core/azure/core/tracing/common.py @@ -90,7 +90,7 @@ def with_current_context(func): :return: The target the pass in instead of the function """ span_impl_type = settings.tracing_implementation() # type: Type[AbstractSpan] - if span_impl_type is not None: + if span_impl_type is None: return func return span_impl_type.with_current_context(func) diff --git a/sdk/core/azure-core/dev_requirements.txt b/sdk/core/azure-core/dev_requirements.txt index 807fefd9ff6d..b90c3caa146b 100644 --- a/sdk/core/azure-core/dev_requirements.txt +++ b/sdk/core/azure-core/dev_requirements.txt @@ -5,4 +5,5 @@ aiodns>=2.0; python_version >= '3.5' typing_extensions>=3.7.2 opencensus>=0.6.0 opencensus-ext-azure>=0.3.1 +opencensus-ext-threading mock \ No newline at end of file