Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Code Editor #3219

Closed
iampremo opened this issue Jun 21, 2023 · 40 comments
Closed

New Code Editor #3219

iampremo opened this issue Jun 21, 2023 · 40 comments
Assignees
Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one)
Milestone

Comments

@iampremo
Copy link
Member

iampremo commented Jun 21, 2023

Complete reworking and architecting of the whole Code Editor within GameMaker.

Teaser Section

Multiple events in one place, plus adding, removing and editing events in one place.

Image

Markdown is now supported in Notes Editor.

Image

@AToska21
Copy link

Would this be something close to GMEdit? That would be cool!

@ahengine
Copy link

Please add configuration to using vscode as ide and add new event functionality like unity and unreal (Awake, Update, OnTrigger)

@iampremo
Copy link
Member Author

add new event functionality like unity and unreal (Awake, Update, OnTrigger)

Please add this as a feature request, events are not part of the code editor

@AToska21
Copy link

AToska21 commented Oct 7, 2023

Please add configuration to using vscode as ide and add new event functionality like unity and unreal (Awake, Update, OnTrigger)

Awake = Create
Update = Step
OnTrigger = Collision ig?

@flashice2030
Copy link

how is it like?

@offalynne
Copy link

offalynne commented Dec 7, 2023

Is Notes Markdown intended to support linking? For example to header hashes, another Note, etc.
If not already so, this would be appreciated for allowing navigation when eg. writing documentation.

@michael-mcmullen
Copy link

Can you ensure that we can add "events" by just typing them and not having to use a mouse? Eg:

#event step

or

#step

This is what gmedit allows

@michael-mcmullen
Copy link

Please also allow something like a "symbol" find for the current document. VSCode has a short cut in their palette @ which you can look for functions. This would be extremely helpful when jumping from the create event into the draw event, and vice versa

@yerumaku
Copy link

Can I expect to view and edit all the timeline moments in one tab?

@yerumaku
Copy link

I vote for quick transitions from Markdown to object events and struct methods.

@NameOfGMObject#step_normal

@NameOfStructCtor#method_name

And load info from Events/Functions JSDOC.

@iampremo iampremo added this to the 2024.2 milestone Jan 5, 2024
@TheHumanistX
Copy link

REALLY hoping you guys took all these suggestions into account and also are just bringing in the simple things like auto-closing brackets... being able to use Alt + Up or Down to shift lines of text around... SHIFT + ALT + Up or Down to duplicate line or section of code... things like that you see in so many other editors! :)

@iampremo iampremo transferred this issue from another repository Jan 9, 2024
@iampremo iampremo added the feature request New feature (or a request for one) label Jan 9, 2024
@kt-altyn
Copy link

could you also add SVG support in addition to PNG?

@iampremo
Copy link
Member Author

iampremo commented Jan 15, 2024

SHIFT + ALT + Up or Down to duplicate line or section of code...

That's what Ctrl + D is for, which you can also rebind if you want ;)

@michael-mcmullen
Copy link

Technically CTRL + D should be used to find the next duplicate ;) Would be helpful if you had code and you highlighted a variable, and hit CTRL + D so that it takes you down to where that variable is found next in the file. (A-la VSCODE/JETBRAINS)

@rwkay
Copy link

rwkay commented Jan 15, 2024

Hmmm I would have used F3 to go to the next thing... never used CTRL+D for this myself...

@XanthorXIII
Copy link

Please add a section for variable definitions above create so we can do away with having to open and close a window for variable definitions all the time. Otherwise looks pretty good.

@rwkay
Copy link

rwkay commented Jan 16, 2024

Please add a section for variable definitions above create so we can do away with having to open and close a window for variable definitions all the time. Otherwise looks pretty good.

You can already use the Inspector to do this... that is the intended workflow

@thennothinghappened
Copy link

Can you ensure that we can add "events" by just typing them and not having to use a mouse? Eg:

#event step

or

#step

This is what gmedit allows

Seconding this, hoping the new editor to be completely functional by keyboard alone

@iampremo iampremo modified the milestones: 2024.2, 2024.4 Jan 26, 2024
@thennothinghappened
Copy link

I'd really like to see non-mouse-based multi-line selections

@matrugdev
Copy link

Not sure if this is the right place for this, but could there be a way to search for event types? For example search and show all objects with Draw Normal Events, or Step Begin Events.

@ParodyKnaveBob
Copy link

Those different levels of colored brackets look like a lovely QOL addition, ty.

@iampremo iampremo moved this from Todo to In Progress in Team Workload Apr 3, 2024
@iampremo iampremo modified the milestones: 2024.4, 2024.6 Apr 3, 2024
@JustMegaAlex
Copy link

Yeah, basically bringing all beloved features from popular programming IDEs like VSCode. That would be a blast
(I'm currently using VSCode a lot but it's not super convenient to constantly switch between GM and VSCode)

@oldtimerza
Copy link

oldtimerza commented May 20, 2024

EDIT: BIG EDIT!!!!! Opening new code editors for objects breaks the keyboard again, going into preferences and toggling and applying the code editor 2 enabled toggle fixes it again. But this needs to be done every time a new code editor is opened. It's almost as if each new code editor window is broken from the start and needs to have the Enabled flag retriggered to begin working.

Love the look and feel of the new Code editor.

Typing in general works fine,. Game maker shortcutes(like ctrl+f) work fine. Right-click selection cut, paste, copy works fine.

However one issue is making it impossible to use, backspace, enter and delete keys(or windows shortcuts ctrl+z, ctrl+x, ctrl+c) on laptop keyboard doesn't work in the code editor.

I press the key and nothing happens. I've checked the "Redefine keys" preference menu and the keys are all correct binding.

Game maker Beta IDE version: 2024.400.0.556

Windows 11 operating system.

@hasnogame
Copy link

hasnogame commented May 21, 2024

@oldtimerza I would recommend downgrading to Beta IDE 2024.400.0.543 until a new beta is released. I believe the April betas are now considered closed due to the release of 2024.4.

It seems this issue was introduced in Beta IDE 2024.400.0.549 as the last version without this issue is Beta IDE 2024.400.0.543.

@oldtimerza
Copy link

Thank you @hasnogame . Will give that a try :)

@hasnogame
Copy link

hasnogame commented May 24, 2024

@oldtimerza Happy to let you know the new June beta released today does not have this issue either. :D

@oldtimerza
Copy link

Speak about timing. That's fantastic!

@iampremo iampremo modified the milestones: 2024.6, 2024.8 Jun 7, 2024
@flashice2030
Copy link

It would be even better if the functionality of debugging code at run time were also made available.

@iampremo iampremo modified the milestones: 2024.8, 2024.10 Aug 2, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo added the documentation Improvements or additions to documentation are required by this issue label Nov 5, 2024
@stuckie
Copy link

stuckie commented Nov 20, 2024

This will be available in monthly, but is still a beta feature ( and is off by default )

@stuckie stuckie closed this as completed Nov 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Nov 20, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo self-assigned this Nov 21, 2024
@yerumaku
Copy link

I still see problems in the latest Beta versions, if I close the IDE with several (large: 30+) open scripts, then the IDE with the code editor 2 enabled cannot start the project and freezes.

Turning off CE2 and starting the project resets the open tabs, which allows you to turn on CE2 and start the project.

It is also noticed that each file opens for a few seconds and disappears 200 MB of memory with each open script (scripts are not large).

@thennothinghappened
Copy link

I still see problems in the latest Beta versions, if I close the IDE with several (large: 30+) open scripts, then the IDE with the code editor 2 enabled cannot start the project and freezes.

Turning off CE2 and starting the project resets the open tabs, which allows you to turn on CE2 and start the project.

It is also noticed that each file opens for a few seconds and disappears 200 MB of memory with each open script (scripts are not large).

File a bug report. This issue tracked getting CE2 mostly there and into monthly.

@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Nov 25, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Ready for QA to Done in Team Workload Nov 25, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Dec 9, 2024
@sihammill
Copy link

Verified as this is now in green, however there are many related issues logged so this particular report can now be closed down.

@sihammill sihammill moved this from Ready for QA to Verified in Team Workload Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one)
Projects
Status: In Beta
Status: Verified
Development

No branches or pull requests