Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-Game: [HTML5] Calling audio_sound_loop_end() on a decoding streamed sound will cause a crash #7805

Closed
toby-yoyo opened this issue Sep 27, 2024 — with GM Bug Reporter · 2 comments
Assignees
Labels
project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Milestone

Comments

@toby-yoyo
Copy link

Description

If a streamed sound is currently decoding, and audio_sound_loop_end is called on it, the runtime will crash due to an attempt to access the data buffer which hasn't been decoded yet.

This will produce the following error:

Uncaught TypeError: this.pbuffersource is null

Steps To Reproduce

  • Open and run the attached project on HTML5.
  • Open the console.
  • Interact with the page to start the test. The game should immediately crash.
  • In the console, scroll all the way to the top and inspect the first error to be thrown. It should be the one from the description.

Which version of GameMaker are you reporting this issue for?

IDE v9.9.1.798 Runtime v9.9.1.960

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

Which platform(s) are you seeing the problem on?

HTML5

96ffc6d9-8f23-4c01-9f73-6f973da6c875

@toby-yoyo toby-yoyo added project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes labels Sep 27, 2024
@stuckie stuckie moved this from Triage to Todo in Team Workload Sep 30, 2024
@stuckie stuckie added this to the 2024.11 milestone Sep 30, 2024
@toby-yoyo
Copy link
Author

Avoided refs to the voice's audio buffer when setting the loop-end bound on a decoding voice.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Sep 30, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Oct 1, 2024
@scott-dunbar
Copy link
Collaborator

Verified fixed in IDE v2024.1100.0.631 Runtime v2024.1100.0.656

@scott-dunbar scott-dunbar moved this from Ready for QA to Verified in Team Workload Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Projects
Status: Verified
Development

No branches or pull requests

3 participants