Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping Unused Assets From Your Export Packages seems to be enabled since 2024.4 #8199

Closed
gnysek opened this issue Oct 30, 2024 · 3 comments
Assignees
Labels
build-bug Bugs when compiling projects inside GameMaker

Comments

@gnysek
Copy link
Contributor

gnysek commented Oct 30, 2024

Description

2024.1100 beta 4 mentions, that there's new feature:

New Game Option For Stripping Unused Assets From Your Export Packages

  • You can now enable whether during builds GameMaker should automatically ignore any unused assets in your projects, so these are not added into your game packages
  • Game Options > Main > “Automatically remove unused assets when compiling”
  • Note that this defaults to ON when creating a new project, but you will need to enable it yourself in your existing projects
  • #3597

And while it says that it's ON by default for new projects I've found out, that it's on for my 2024.4.0.137 project, that it's enabled by default in all monthly and betas from that moment.

Expected Change

This might affect existing projects and people might be unaware it's enabled for them.
When opening pre 2024.11 project, and "option_remove_unused_assets": is set to true, there could be a warning message, if we want to keep it "on".

Steps To Reproduce

  1. Check some older project from disk
  2. Open .yyp to check IDE
  3. Open /options/main/options_main.yy to check for "option_remove_unused_assets":true,

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2024.1100 (Betas)

Which operating system(s) are you seeing the problem on?

Windows 11, Ubuntu 22 LTS

@gnysek gnysek added the build-bug Bugs when compiling projects inside GameMaker label Oct 30, 2024
@gnysek gnysek changed the title Stripping Unused Assets From Your Export Packages is true for older projects too Stripping Unused Assets From Your Export Packages seems to be enabled since 2024.4 Oct 30, 2024
@stuckie stuckie self-assigned this Oct 31, 2024
@stuckie stuckie moved this from Triage to Backlog in Team Workload Oct 31, 2024
@stuckie
Copy link

stuckie commented Nov 4, 2024

This should only have affected new projects since 2024.04 - any existing ones that were created from before should still have this off by default.

It isn't something we can easily go back and change now, and preferably if there are problems with this feature when using 2024.11, we'd like to know so we can fix them rather than you turning the setting back off or reverting to an older IDE and therefore not reporting any bugs for 2024.11 (we don't need bug reports for problems with this feature in the old IDEs/runtimes).

What has happened is that now the feature flag has been set on it's triggering the code to use it, but not everything was feature flag aware to begin with. This is something we'll work on in future, but again, this won't affect already-released versions.

@stuckie stuckie closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Team Workload Nov 4, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Not Planned in Team Workload Nov 5, 2024
@gnysek
Copy link
Contributor Author

gnysek commented Nov 5, 2024

@stuckie

It isn't something we can easily go back and change now

It can be easily fixed. Just rename option_remove_unused_assets to something else (option_purge_unused_assets maybe?), then this preference for 2024.4+ projects won't be used, and it will be available since 2024.11 :)

@stuckie
Copy link

stuckie commented Nov 5, 2024

We have now fixed this for the next beta where all previous projects will have this set to false, and any new projects from the next beta onwards, will have it on by default.
There will be other details as well on the changes, so please be sure to read the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-bug Bugs when compiling projects inside GameMaker
Projects
Status: Not Planned
Development

No branches or pull requests

2 participants