Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-Game: Inherited functions are not overridden if called from an inherited event in 2024.1100 runtimes #8434

Closed
2 tasks done
protogenposting opened this issue Nov 16, 2024 · 7 comments
Assignees
Labels
runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Milestone

Comments

@protogenposting
Copy link

Description

This is a really freaky bug.

basically, calling a function in an inherited event will call the function that was originally created in the inherited event. Idk how to explain it better

https://api.gamemaker.io/api/github/downloads/893e65d2-7206-4da9-91fb-942f025038ae

here's a small test project

Override test.zip

Expected Change

No response

Steps To Reproduce

  1. Start GameMaker
  2. Load the test project
  3. Run it
  4. press space
  5. See the issue

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2024.1100 (Betas)

Which platform(s) are you seeing the problem on?

Ubuntu

Sample Package Attached?

  • I have attached my bug package

Sample Project Added?

  • I have included a small sample project
@protogenposting protogenposting added the runner-bug In-game bugs with the "GameMaker Studio 2" runtimes label Nov 16, 2024
@protogenposting
Copy link
Author

apparently I wasn't on the latest beta. Updating to the new runtime did not fix the issue though

@stuckie stuckie changed the title Inherited functions can't be ovverridden if called from and inherited event Inherited functions can't be overridden if called from an inherited event Nov 18, 2024
@stuckie stuckie moved this from Triage to Backlog in Team Workload Nov 18, 2024
@rwkay rwkay added this to the 2024.11 milestone Nov 18, 2024
@rwkay rwkay moved this from Backlog to Todo in Team Workload Nov 18, 2024
@rwkay rwkay moved this from Todo to In Progress in Team Workload Nov 18, 2024
@Notlea
Copy link

Notlea commented Nov 19, 2024

Got the same issue. In my case I have an empty state declared in the parent object that is being overwritten in the child. When the child performs a call to a new function, it actually invokes empty function from the parent. I have to mention, that empty function is assigned at the parent, not in the child.
Parent:

//create event
state_idle = function() {
};
state = state_idle;
    //step event
state();

Child:

state_idle = function() {
    //some logic to perform
};

I solved my issue by explicitly assigning state in the child:
Child:

//create event
state_idle = function() {
    //some logic to perform
};
state = state_idle; //reassignment
//step event is still inherited

I'm using IDE 2024.6.2.162 with Runtime 2024.6.1.208

@rwkay
Copy link

rwkay commented Nov 19, 2024

Fixed in 2024.11 - not sure what the issue is in the above comment but the bug here was only present in the 2024.11 Beta

@rwkay rwkay closed this as completed Nov 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Nov 19, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Nov 20, 2024
@Emc1923 Emc1923 self-assigned this Nov 20, 2024
@Emc1923
Copy link

Emc1923 commented Nov 20, 2024

@rwkay will this fix be implemented for the HTML5 target as well? Thank you.

@Emc1923
Copy link

Emc1923 commented Nov 22, 2024

Reopening to get the fix added for HTML5

@Emc1923 Emc1923 reopened this Nov 22, 2024
@github-project-automation github-project-automation bot moved this from Ready for QA to Triage in Team Workload Nov 22, 2024
@stuckie stuckie moved this from Triage to Todo in Team Workload Nov 25, 2024
@rwkay
Copy link

rwkay commented Nov 25, 2024

Fixed in 2024.11

@rwkay rwkay closed this as completed Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Workload Nov 25, 2024
@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Nov 25, 2024
@Emc1923
Copy link

Emc1923 commented Nov 27, 2024

Verified fixed in IDE v2024.1100.0.699 Runtime v2024.1100.0.717.

@Emc1923 Emc1923 moved this from Ready for QA to Verified in Team Workload Nov 27, 2024
@YYDan YYDan changed the title Inherited functions can't be overridden if called from an inherited event In-Game: Inherited functions are not overridden if called from an inherited event in 2024.1100 runtimes Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Projects
Status: Verified
Development

No branches or pull requests

4 participants