Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Content: Line breaks are removed from <pre> contents when the search facility highlights text within it #8832

Closed
L-Clouds opened this issue Dec 21, 2024 · 2 comments
Assignees
Labels
docs-bug GameMaker Manual Bugs
Milestone

Comments

@L-Clouds
Copy link

Description

If you perform a search in the manual and visit one of the results, if the search highlights text that's inside a <pre> tag, new lines are stripped from the <pre> tag's contents - not that the CSS stops preserving line breaks, but the line breaks are actually absent from the HTML text content. The "Remove Highlights" button does not bring them back.

Examples:
First shader code example is missing line breaks: https://manual.gamemaker.io/monthly/en/#t=GameMaker_Language%2FGML_Reference%2FDrawing%2FVideos%2FYUV_Videos.htm&rhsearch=sampler2d&rhhlterm=sampler2d
Image

Same page, but with a different search having been performed, first shader code example is OK, second shader code section is missing line breaks: https://manual.gamemaker.io/monthly/en/#t=GameMaker_Language%2FGML_Reference%2FDrawing%2FVideos%2FYUV_Videos.htm&rhsearch=video_get_format&rhhlterm=video_get_format
Image

Manual Link

No response

@L-Clouds L-Clouds added the docs-bug GameMaker Manual Bugs label Dec 21, 2024
@jackerley jackerley moved this from Triage to Backlog in Team Workload Dec 23, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Backlog to Todo in Team Workload Dec 24, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo added this to the 2024.13 milestone Dec 24, 2024
@gurpreetsinghmatharoo
Copy link

This was an issue on just the YUV Videos page, the code blocks weren't formatted properly. I've fixed that in the source.

@mgeddesGM
Copy link

verified

@mgeddesGM mgeddesGM moved this from Ready for QA to Verified in Team Workload Jan 3, 2025
@YYDan YYDan changed the title Line breaks are removed from <pre> contents if the search highlights text within it Manual Content: Line breaks are removed from <pre> contents when the search facility highlights text within it Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-bug GameMaker Manual Bugs
Projects
Status: Verified
Development

No branches or pull requests

3 participants