UI Layers: depth variable affects draw order of UI instances

[gurpreetsinghmatharoo]

Description

UIL_Tutorial_Ahead_Pause.zip

Run the project and the UI buttons won't appear.

This is because of the code in obj_player End Step event:

with (all)
{
    depth = -bbox_bottom;
}

Disabling this code makes the buttons appear again.

Expected Change

Setting the depth of a UI layer instance should not change its draw order.

Steps To Reproduce

1. Start GameMaker
2. Follow steps above
3. See the issue

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2024.1300 (Betas)

Which platform(s) are you seeing the problem on?

Windows

Sample Package Attached?

• I have attached my bug package

Sample Project Added?

• I have included a small sample project

[jackerley]

This isn't incorrect functionality, it is sorting the instances on the ui layer according to depth. After some discussion instead of changing this, we'll add some helper functions, layer_get_type and is_on_gui_layer as an instance method to make it simple to avoid this behaviour if you wish to only do something to room space instances etc.