Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help center button too tall in IE11 #746

Open
afercia opened this issue Sep 28, 2018 · 1 comment
Open

Help center button too tall in IE11 #746

afercia opened this issue Sep 28, 2018 · 1 comment

Comments

@afercia
Copy link
Contributor

afercia commented Sep 28, 2018

In IE11 the Help Center button looks taller than in other browsers:

screenshot 96

HelpCenterButton extends YoastButton which uses a CSS hack to fix an IE11 bug with min-height and flexbox.

// Only needed for IE 10+. Don't add spaces within brackets for this to work.
@media all and (-ms-high-contrast: none), (-ms-high-contrast: active) {
::after {
display: inline-block;
content: "";
min-height: ${ `${ ieMinHeight }px` };
}
}

So its min-height is hardcoded to 48 pixels because this value was the design requirement. If we want to change the min-height, then also the hack for IE11 needs to be adjusted accordingly.

@afercia
Copy link
Contributor Author

afercia commented Sep 28, 2018

See the branch 746-help-center-button-height-ie11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant