From b995911ef71f7362a04fdee1f4af507281bf14f5 Mon Sep 17 00:00:00 2001 From: VampireChicken12 Date: Tue, 18 Jun 2024 09:55:13 -0400 Subject: [PATCH] fix: old button placement not being removed --- src/pages/embedded/index.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/pages/embedded/index.ts b/src/pages/embedded/index.ts index 592dce74..01428d9b 100644 --- a/src/pages/embedded/index.ts +++ b/src/pages/embedded/index.ts @@ -725,8 +725,10 @@ window.addEventListener("DOMContentLoaded", function () { case "playbackSpeedButtons": { for (const [buttonName, { new: newPlacement, old: oldPlacement }] of Object.entries(changes)) { if (oldPlacement === newPlacement) continue; - await removeDecreasePlaybackSpeedButton(); - await removeIncreasePlaybackSpeedButton(); + const increasePlaybackSpeedButtonFuncs = getFeatureFunctions("increasePlaybackSpeedButton", oldPlacement); + const decreasePlaybackSpeedButtonFuncs = getFeatureFunctions("decreasePlaybackSpeedButton", oldPlacement); + await decreasePlaybackSpeedButtonFuncs.remove(); + await increasePlaybackSpeedButtonFuncs.remove(); switch (buttonName) { case "increasePlaybackSpeedButton": case "decreasePlaybackSpeedButton": { @@ -734,12 +736,12 @@ window.addEventListener("DOMContentLoaded", function () { case "below_player": case "player_controls_left": case "feature_menu": { - await addDecreasePlaybackSpeedButton().then(addIncreasePlaybackSpeedButton); + await decreasePlaybackSpeedButtonFuncs.add().then(increasePlaybackSpeedButtonFuncs.add); break; } // Because of how the right controls are placed in the DOM, we need to add the buttons in reverse order case "player_controls_right": { - await addIncreasePlaybackSpeedButton().then(addDecreasePlaybackSpeedButton); + await increasePlaybackSpeedButtonFuncs.add().then(decreasePlaybackSpeedButtonFuncs.add); break; } }