This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat(pSTAKE): Add new app pSTAKE with token fetcher #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immasandwich
reviewed
Sep 9, 2022
There was a problem hiding this comment.
Replace the assets/pSTAKElogo.png file with logo.png like
https://s2.coinmarketcap.com/static/img/coins/200x200/15996.png
immasandwich
reviewed
Sep 9, 2022
immasandwich
reviewed
Sep 9, 2022
src/apps/pstake/binance-smart-chain/pstake.Stake.token-fetcher.ts
Outdated
Show resolved
Hide resolved
|
Few comments, otherwise looks great! |
|
Can you please review. Thanks. |
|
@immasandwich @kafitz @maximebedard @mikeshultz Can you please re review? |
|
HEY @immasandwich can. you review soon pls? |
immasandwich
approved these changes
Sep 25, 2022
|
Hello @vedantd - thanks for submitting this! qq- do you have an ENS or address you'd want us to attribute this contribution to? We are building out a leaderboard to give credit to users who contributed to Zapper, with potential bonus points of value in the future. Let me know, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description