This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix(vendor-finance): fix lender positions after migration #1752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the migration to the new template, one part of the integration was failing.
A vendor pool consist of :
ContractPosition
ContractPosition
The "lent out" and "borrowed" token is the same, and has to be present with two different status
SUPPLIED
andBORROWED
.For example a wETH/USDC pool where you can borrow USDC against wETH
If the user querying is the lender ( pool creator/deployer ), the returned balances array is
If he is a borrower
Checklist
How to test?
AppId
vendor-finance
Lender : http://localhost:5001/apps/vendor-finance/balances?addresses%5B%5D=0x38BDa44E85610BB5d737A6ab5CCd09f173b5ecAF&network=arbitrum
Borrower : http://localhost:5001/apps/vendor-finance/balances?addresses%5B%5D=0xcba1a275e2d858ecffaf7a87f606f74b719a8a93&network=arbitrum