This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat(redacted-cartel): add support for claimable rewards #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you notice there's a |
Ah no I didn't. Is it okay if we go forward with this, or do you want me to rewrite it using the template? Look at that template, we would've had to make some modifications anyway, since the rewards aren't getting pulled from the chain, but from an http api, so things like |
|
It's ok, don't worry. Last question before I merge, is there a way to get rewards using call on chain instead of an external API? |
0xdapper
pushed a commit
to 0xdapper/studio
that referenced
this pull request
Feb 28, 2023
) * feat(redacted-cartel): remove old fetcher * feat(redacted-cartel): add new fetcher --------- Co-authored-by: William Poulin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the current redacted-cartel revenue locked contract position. The old one was extending
VotingEscrowTemplateContractPositionFetcherwhich does not support easily adding rewards.This change switches the implementation to a standard
ContractPositionTemplatePositionFetcherand adds support for fetching claimable rewards (from Redacted's API).Checklist