Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(tags): Update the app tags, make mandatory #349

Merged
merged 7 commits into from
May 3, 2022
Merged

feat(tags): Update the app tags, make mandatory #349

merged 7 commits into from
May 3, 2022

Conversation

JForsaken
Copy link
Contributor

Description

  • Rename ProtocolTag and ProtocolAction
  • Update the tags to be more detailed/descriptive
  • Update CLI to match changes

Checklist

@JForsaken JForsaken changed the title New tags feat(tags): Update the app tags, make mandatory May 3, 2022
immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/aelin/aelin.definition.ts Outdated
@@ -19,10 +19,10 @@ export const AELIN_DEFINITION: AppDefinitionObject = {
discord: 'https://t.co/kG6zsC0zaR',
medium: 'https://medium.com/@aelinprotocol',
},
tags: [ProtocolTag.LENDING],
tags: [AppTag.LENDING],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppTag.LAUNCHPAD

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/alpha-v1/alpha-v1.definition.ts Outdated
@@ -16,9 +16,9 @@ export const ALPHA_V1_DEFINITION = {
discord: 'https://discord.com/invite/2My6wKt',
telegram: 'https://t.me/AlphaFinanceLab',
},
tags: [ProtocolTag.LENDING],
tags: [AppTag.LENDING],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also FARMING

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/keeper-dao/keeper-dao.definition.ts Outdated
@@ -20,8 +20,8 @@ export const KEEPER_DAO_DEFINITION: AppDefinitionObject = {
v3Pool: { id: 'v3-pool', type: GroupType.TOKEN },
farm: { id: 'farm', type: GroupType.POSITION },
},
tags: [ProtocolTag.YIELD_AGGREGATOR],
supportedNetworks: { [Network.ETHEREUM_MAINNET]: [ProtocolAction.VIEW] },
tags: [AppTag.YIELD_AGGREGATOR],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently DEX

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/lido/lido.definition.ts Outdated
@@ -19,9 +19,9 @@ export const LIDO_DEFINITION: AppDefinitionObject = {
steth: { id: 'steth', type: GroupType.TOKEN },
wsteth: { id: 'wsteth', type: GroupType.TOKEN },
},
tags: [ProtocolTag.DERIVATIVES],
tags: [AppTag.DERIVATIVES],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIQUID_STAKING

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/liquity/liquity.definition.ts Outdated
@@ -21,9 +21,9 @@ export const LIQUITY_DEFINITION: AppDefinitionObject = {
trove: { id: 'trove', type: GroupType.POSITION },
stabilityPool: { id: 'stability-pool', type: GroupType.POSITION },
},
tags: [ProtocolTag.LENDING],
tags: [AppTag.LENDING],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDP

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/jpegd/jpegd.definition.ts Outdated
@@ -18,9 +18,9 @@ export const JPEGD_DEFINITION: AppDefinitionObject = {
pool: { id: 'pool', type: GroupType.POSITION },
bond: { id: 'bond', type: GroupType.POSITION },
},
tags: [ProtocolTag.LENDING],
tags: [AppTag.LENDING],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDP

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/pie-dao/pie-dao.definition.ts Outdated
@@ -21,9 +21,9 @@ export const PIE_DAO_DEFINITION: AppDefinitionObject = {
telegram: 'https://t.me/piedao',
medium: 'https://medium.com/piedao',
},
tags: [ProtocolTag.LIQUIDITY_POOL],
tags: [AppTag.LIQUIDITY_POOL],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASSET MANAGEMENT

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/synthetix/synthetix.definition.ts Outdated
@@ -19,10 +19,10 @@ export const SYNTHETIX_DEFINITION: AppDefinitionObject = {
discord: 'https://discord.com/invite/AEdUHzt',
telegram: 'https://t.me/s/havven_news',
},
tags: [ProtocolTag.LIQUIDITY_POOL],
tags: [AppTag.LIQUIDITY_POOL],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYNTHETICS

immasandwich
immasandwich reviewed May 3, 2022
View reviewed changes
src/apps/teddy-cash/teddy-cash.definition.ts Outdated
@@ -20,9 +20,9 @@ export const TEDDY_CASH_DEFINITION: AppDefinitionObject = {
trove: { id: 'trove', type: GroupType.POSITION },
stabilityPool: { id: 'stability-pool', type: GroupType.POSITION },
},
tags: [ProtocolTag.LENDING],
tags: [AppTag.LENDING],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDP

@JForsaken JForsaken merged commit f38832f into main May 3, 2022
@JForsaken JForsaken deleted the new-tags branch May 3, 2022 20:08
@zapper-bot zapper-bot mentioned this pull request May 3, 2022
Merged
@zapper-bot zapper-bot mentioned this pull request Jun 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@immasandwich immasandwich immasandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JForsaken @immasandwich