Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: add aladdin dao concentrator #423

Merged
merged 7 commits into from
May 12, 2022
Merged

Conversation

tonzgao
Copy link
Contributor

@tonzgao tonzgao commented May 12, 2022

Description

added app concentrator: https://concentrator.aladdin.club/#/vault

note: im not a member of this project, just want to see my balances

Checklist

How to test?

you can find pool depositors here: https://etherscan.io/address/0xc8fF37F7d057dF1BB9Ad681b53Fa4726f268E0e8

@tonzgao
Copy link
Contributor Author

tonzgao commented May 12, 2022

@immasandwich btw, i have a question - you can see there are a few comments about rewards todo. this is because the token for rewards is the one added in the token fetcher. do you know how to properly handle this? i image its something like injecting the token fetcher into the balance fetcher and calling getPositions(); either that or there should be some sort of recipe for it. can you point me to an app which implements either of these patterns?

@immasandwich
Copy link
Contributor

Hey @tonzgao , great PR! I've left a few comments, one of which addresses how to resolve the aCRV reward token. If you have any questions, let us know, and we'd love your feedback in Discord.

@tonzgao tonzgao requested a review from immasandwich May 12, 2022 16:59
@immasandwich immasandwich merged commit da5fb42 into Zapper-fi:main May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants