feat: add plutus dao #497
feat: add plutus dao #497
Conversation
| ) {} | ||
|
|
||
| async getPositions() { | ||
| return this.appToolkit.helpers.singleStakingFarmContractPositionHelper.getContractPositions<MasterChef>({ |
There was a problem hiding this comment.
Use the MasterChefFarmContractPositionHelper instead. It can dynamically resolve the number of pools in the chef (in case Plutus decides to add new pools to these chef contracts).
There was a problem hiding this comment.
Also, perhaps rename this MasterChef to PlsPlutusChef (rename master-chef.json to pls-plutus-chef.json, then regenerate the contract factory). This will be more aligned with the naming of the other chefs you have in this integration.
There was a problem hiding this comment.
So I dont see any class or file named MasterChefFarmContractPositionHelper, are you referring to something else? maybe in the private repo?
There was a problem hiding this comment.
Re number of pools and the name, I did adjust it. But the contract itself has the name MasterChef. I think they were in a hurry to deploy and didnt have the confidence to personalize the contract, and therefore left the pool length parameters in. Either that, or its for upgradeability. I dont think there's a use case to split up plutus staking into multiple pools.
There was a problem hiding this comment.
I see, you mean the MasterChefContractPositionBalanceHelper
src/apps/plutus/arbitrum/plutus.dpx.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
src/apps/plutus/arbitrum/plutus.jones.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
Description
add plutus dao
note: not affiliated with the project
Checklist
How to test?
see addresses in consts.ts