-
Notifications
You must be signed in to change notification settings - Fork 383
Conversation
const decimals = await multicall.wrap(contract).decimals(); | ||
const pricePerShare = await multicall.wrap(contract).getPricePerFullShareStored(); | ||
return Number(pricePerShare) / 10 ** Number(decimals); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default label as the symbol isn't great: TYS-stETH-31-2-2022
I'd suggest we override the label with resolvePrimaryLabel
, and set it to stETH Yield Share (Maturity: 31/02/2022)
(or for principal, stETH Principal Share (Maturity: 31/02/2022)
). You can also adjust the vault helper to add a resolveTertiaryLabel
if you want the maturity outside of the primary label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, the symbol names dont seem to be consistent between eth mainnet and fantom, and im not sure how they might change in the future. is it okay to just leave this as it for now? or if the tempus team has a suggestion about deriving labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup it's ok to come back and address this later. I'll update the VaultTokenHelper
between now and then so that you'll be able to update the tertiaryLabel
in the future if necessary.
note
|
Description
add tempus finance. see https://discord.com/channels/647279669388771329/964569348243075082/983794842830250065
not affiliated with project, but they are giving me a grant for this.
discussions below:
Checklist
How to test?
http://localhost:5001/apps/tempus/tokens?network=ethereum&groupIds%5B%5D=pool
http://localhost:5001/apps/tempus/tokens?network=ethereum&groupIds%5B%5D=amm
http://localhost:5001/apps/tempus/balances?network=ethereum&addresses%5B%5D=0xab40a7e3cef4afb323ce23b6565012ac7c76bfef
tempus team, please confirm the below looks correct: