-
Notifications
You must be signed in to change notification settings - Fork 382
feat(iron-bank): added iron bank to Zapper #617
Conversation
Hello @reganwrench ! Instead of copying the helpers from |
I'll add a recipe this weekend to the Studio documentation to clarify why/how that works. |
ser, i have pushed an update that uses the helpers from compound directly. thank you. |
@@ -0,0 +1,63 @@ | |||
import { Inject, forwardRef } from '@nestjs/common'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the file to iron-bank.balance-fetcher.ts
(use kebab case for filenames 🙏 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
const lendingProduct = { label: 'Lending', assets: [...supplyBalances, ...borrowBalances], meta }; | ||
|
||
return presentBalanceFetcherResponse([lendingProduct]); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have some lint errors, run pnpm lint:fix
to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
network, | ||
appId, | ||
groupId, | ||
comptrollerAddress: '0x2eE80614Ccbc5e28654324a66A396458Fa5cD7Cc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase address 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
network, | ||
appId, | ||
groupId, | ||
comptrollerAddress: '0xAB1c342C7bf5Ec5F02ADEA1c2270670bCa144CbB', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
network, | ||
appId, | ||
groupId, | ||
comptrollerAddress: '0x4250A6D3BD57455d7C6821eECb6206F507576cD2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@reganwrench Last few requests:
Then we're ready! I'll slap an approval on this too right now. |
* added iron bank integration * add avax and ftm * update ib integration * update file name and comptroller address, and fixed lint issues * fixed module import paths
all done. thank you ser |
Hello @reganwrench ! Looks like you did not provide an address when submitting your PR. I recognize it may have seemed kind of random that we were asking for a wallet address with a PR submission, but we are actually looking for ways to reward Studio contributors in the future. Is there an address you’d want to provide? Could even be an empty address, if you do not have an doxxed address Let me know! Also, if you’d like to privately provide it, feel free to shoot me a TG https://t.me/SamIAm_0x or DM on the Zapper Discord. Thanks! |
@SamIam-0x |
Description
Adding integration of Iron Bank (ETH, FTM, AVAX)
Checklist
How to test?